[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#591302: About 7kaa



2011/3/15 Bertrand Marc <beberking@gmail.com>:
> Le 11/03/2011 02:33, Miriam Ruiz a écrit :
>
> Cool!
>
> I've uploaded my changes to SVN, please have a look at them when you
> have some spare time, and fix whatever you think could be improved.
> I'll upload it to Debian when I get the green light from you :)
>
> Greetings,
> Miry
>
>
> Hi Miriam,
>
> Thanks for your work on 7kaa ! Especially for the use of the new config
> chain with autotools, which I know only a little. I had a look at your work
> and I have a couple of questions. I am still shy to change something a DD
> did, therefore I didn't commit anything :

Don't worry, there's usually not a single way to do things, and your
proposals will probably be as good as mine. In any case, if there's
some problem, we can always revert  them :)

> * the clean target depends on the config target. Is it standard ? It makes
> my usual command line to build with pdebuild fail.

Nah, you can safely remove it. I'll change it in SVN.

> * I read carefully /usr/share/doc/autotools-dev/README.Debian.gz which I
> didn't know. As I understand it, their advice is to rerun all the autotools
> before config (method 1). I also understood that the files generated by
> autotools should be purged by the clean target and should not even be in the
> orig tarball. Again, I never packaged anything using autotools and I am
> quite new to this so correct me if I'm wrong.

That's an option, but to prevent problems I tend not to rerun it
unless I have patched the autotools source, which wasn't needed here.
If you want to rerun it, it would be OK too. Except in some cases,
there are usually no big problems.

> * Last, there seems to be dh_autotools-dev_restoreconfig and
> dh_autotools-dev_updateconfig to copy the config.* files. Isn't it better
> (more robust) to use these ?

I've never tried them, but feel free to use them if you want :)

> Cheers,
> Bertrand

Greetings,
Miry



Reply to: