Bug#589254: RFS - mapcatcher
Hello,
I came across your g/mapcatcher package today, I had not heard of the project before. This looks like an excellent lightweight alternative to marble - I have already installed it on my machine (marble wont fit, it has way too many deps).
I can't sponsor you, however here are some comments on your debian-mentors package:
* Program should use either mapcatcher or gmapcatcher consistently. If upstream wish to rename their project, use mapcatcher, if not, use gmapcatcher. Until I read your mailing list thread, I thought the G was for GTK. This is confusing as some things (eg the program) are labelled mapcatcher, and some things /usr/share/pyshared/* are labelled GMapCatcher. Consistency is key, with or without "G". :)
* Although marked as GPL2 or any later, the actual python programs do not have the pre-amble in the source files, as required by the licence. The upstream project website simply says GPL2, not GPL2 or later. This needs to be clarified by the upstream authors. THis is true of both the mapcatcher and mapdownloader python scripts, as well as for /usr/share/pyshared/gmapcatcher/*
* Project seems to include its own version of gps.py. Is there any reason that the python-gps package is not being used? Importing sources from upstream projects is not cool, as it means that updates are not sent to users in a timely fashion, and that duplication can be a problem. Secondly, this is a problem as it is unclear which files in the pyshared/gmapcatcher/ directory were actually written by the project, and thus are correctly licenced
* During the package build from the DSC, I get the following message:
WARNING: Use of XS-Python-Version and XB-Python-Version fields in debian/control is deprecated with pysupport method; use debian/pyversions if you need to specify specific versions.
pyversions: missing XS-Python-Version in control file, fall back to debian/pyversions
*The installed /usr/share/pyshared/GMapCatcher-0.7.2.2.egg-info contains "UNKNOWN" entries. Please fill in the upstream author's details
*According to debian/copyright, there are two real authors, and then a pseudo-author "mapcatcher team". The upstream project states that the authors are : "pi3orama@gmail.com, HelderSepu@gmail.com, Maxim.Razin@gmail.com, and standa31415@gmail.com". This should be reflected in debian/copyright
Thanks,
D. Haley
Reply to: