[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#566880: Debian #566880: AllTray in Debian (and Ubuntu)



Hi,

On Sun, 07 Mar 2010, Ignace Mouzannar wrote:
> I have just committed my changes in the SVN repository. Also, I have
> uploaded my package on m.d.n [1].

No need to upload the package to mentors.debian.net, I'll rebuild from SVN
anyway.

For the next update, you could use "dh --with autotools_dev", it's a recent
addition to autotools-dev so you will have to adjust the build dependency.
That way you can get rid of debian/clean and the override in
debian/rules.

Other small remarks:
- the name of the patch is "01_minor_type.diff" instead of
  "01_minor_typo.diff"
- the Description field in that patch is not correct, you must put
  something in the first line (short description)
- you have not indicated that the patch has been forwarded, did you
  forward it?
- the category "Applications/Graphics" in the menu is certainly not
  the good category, alltray is not about manipulating images...

I have uploaded your package despite those small remarks, it's good work
overall. Just fix those details for the next update.

Cheers,
-- 
Raphaël Hertzog

Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/



Reply to: