Hi Ding,
Sorry for the late reply.
On Tuesday 05 August 2008 09:32, Ding Honghui wrote:
> I has update the fields and reupload the package to mentors.debian.org.
> And I will commit in the codes to svn when I'm approved to.
Ok, good. I've uploaded your package. For further uploads of curlftpfs, please
contact me directly.
I still have some comments on the current package which you should keep in
mind for the future and/or fix in the next revision:
From your .diff.gz:
> +curlftpfs (0.9.2-1) unstable; urgency=low
> +
> + * New upstream release. (closes: #480320,#449207,#461455)
Unless all three bugs are about packaging the new upstream release, this is a
bad habit of writing a changelog entry. Better would be something like this:
* New upstream release. (closes: #999111)
- Fixes bug A. (closes: #123456)
- Fixes problem when doing this and that. (closes: #123457)
Bug #999111 is then the report which is about packaging the new upstream
release.
Second, the build-dependency on libcurl4-gnutls-dev should be versioned, it
should be "libcurl4-gnutls-dev (>= 7.17.0)" because libcurl4-gnutls-dev
packages existed which does not fullfill the above requirement.
See Debian Policy for reference:
> 4.2 Package relationships
> [...]
> If build-time dependencies are specified, it must be possible to build the
> package and produce working binaries on a system with only essential and
> build-essential packages installed and also those required to satisfy the
> build-time relationships (including any implied relationships). In
> particular, this means that version clauses should be used rigorously in
> build-time relationships so that one cannot produce bad or inconsistently
> configured packages when the relationships are properly satisfied.
Cheers,
--
Frank S. Thomas <fst@debian.org> PGP public key ID: 0xDC426429
Debian Developer finger fst/key@db.debian.org
Attachment:
signature.asc
Description: This is a digitally signed message part.