[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#293316: Anything new with this package ?



Le Sunday 18 November 2007 20:41:11, vous avez écrit :
> > I'm able to do any help. Please just tell me what to do, I'll do it. I
> > don't think to package this software is so hard. :)
>
> I can confirm since I have already made it. ;)

Well, packaging one application is not enough, it also have to be done 
properly :)

> > I don't mind group maintaining. Since to package this software is not
> > very very hard, so group maintaining is not very urgent. I just want to
> > see this software in Debian repository soon. But group maintaining is
> > somewhat better because when this software has new upstream version, we
> > only need one of the group member to have free time to update it :)
> >
> > However, I'm not a DD so I can't help uploading :(
> > Just ask me to do other job that don't need DD's privilege.
>
> Maybe Romain could be in charge of the upload, Ying-Chun and me would
> patch/package ?

Ok, let me speak clearly, and please don't read any agression there, I just 
want to adress things directly.

Yomgui, this ITP has been opened for almost two years now, but no upload has 
been done so far.
As for what I can read, you have it reviewed by Piem, and claimed it was about 
to be uploaded, but still nothing hapened. Did you submit it for review 
on -mentors ? Did Piem has any review ? What were his remarks ?

I've got your package from the links provided, and it seems that it has not 
been changed since 2005 (I'll come back on details on this later in this 
mail).

Now comes another interested packager, asking you to either finish it or let 
him do the work, to which you replied last february that it was about to be 
uploaded, and still nothing.

Of course no one wants to steal your efforts, but clearly there must be some 
explanations there. Of course also, it's possible that you were waiting for 
another reviewer/uploader, but that seems long since February...

Now, I came to the same issue.
I've experienced a similar pattern when mediawiki was about to be packaged and 
many claimed they were willing to contribute. Our solution was to open a 
team.

So I was proposing you this in order to please everyone: of course, we won't 
steal your work, but also we all acknowledge that we want to work on this 
package with the will that it'll be more quickly ready when working as a 
team.


Now, some review on the package.
First of all, having a package that builds and installs is not enough to say 
the work is done. As for I've seen from your package, it's mostly the dh_make 
templates, with non needed files removed. So, I can remark the following:

* debian/rules: please remove non needed code that helps making it readable

* debian/dirs contains /usr/sbin, is a binary installed there ?

* debian/copyright: authors is not only oddsock, I can find files with the 
FSF..  Furthermore, those files seems to be redundant (getopt.c), you may 
look wether you can user external libraries for that.
  You must also include some sort of header for the license and check file by 
file (it's not a lot in this case)

* debian/control: update standard-version (as requested previously)

* debian/changelog: multiple * entries
 Also, you should close the ITP there.


Furthermore, the packaging is distributed with a eztream_0.2.0-1.tar.gz, this 
is wrong, you should seperate upstream's tarball from debian's modifications, 
with a .orig.tar.gz and a diff.gz.


Thoses were the most obvious remarks I could find for now (didn't build it), 
but they must be addressed before any upload can happen..


To conclude, I would like to ask you again wether you'd accept to maintain it 
with a team.
Please answer clearly to that question, it's the moment to raise your feelings 
about this packaging...

In any case, issues above may be corrected before we upload anything...


Romain




Reply to: