Bug#398198: Last update on pkg
Am Sonntag, den 01.04.2007, 09:31 +0200 schrieb Loïc Minier:
> Hi,
>
> On Sun, Apr 01, 2007, Marc-André Lureau wrote:
> > I made some changes based on the comments of Loic. Thanks again for your
> > helpful review. I hope you can upload vala soon.
Marc-André: Thank you for your updates.
> Err, you started from a fully different package and you attached the
> diff against another upstream version! This doesn't ease review to say
> the least.
Well, guess I am to blame for this confusion: Didn't find Marc-André's
package initially, so I started independently.
> I don't understand exactly why you're sending me a diff where
> Mathias Hasselmann is the maintainer.
Seems Marc-André likes the compact CDBS approach I found by
accident. ;-)
> Marc-André, Mathias: who is going to maintain the package for Debian?
I am very interested in getting that package into Debian (and Ubunutu).
So I am interested in keeping that package up-to-date. On the other hand
I don't have much knowledge about Debian package maintenance and I also
do not want to dive too deeply into this matter. So I am pretty fine, if
we both are listed as maintainer, but I'll also will not hide, when
Marc-André wants to focus on other things but the vala package. Just
need someone who tolds me, when I do not meet Debians packaging
standards.
> Marc-André or Mathias, I will need to know where you downloaded
> Mathias' packaging from and/or under which license the packaging by
> Mathias is.
My packaging variant should be found within this ticket. License? Didn't
expect I'd have to declare some license terms for stuff like packaging.
Expected packaging to happen under the same license as the packaged
application -- LGPL-2.1 in the case of Vala.
Oh, after reading the Marc-André's initial diff I see my mistakes.
Seems like Unbuntu is more lax regarding content of the copyright file.
> Marc-André, there are plenty of problems with the second diff you sent
> me and we're going backwards since my last review: the ITP isn't closed
> by your changelog, you're not listed as maintainer, the copyright is
> incomplete (it doesn't have the license block), config.guess and .sub
> are not updated automatically anymore, there are missing
> build-dependencies, etc.
Marc-André is not to blame for those regressions. It was me who didn't
pay enough attention to detail for the reason of not understanding them
all.
Config.guess and .sub are not updated anymore, as I removed
simple-patchsys.mk, which merges buildcore.mk from my rules file.
Going to update the diff right now.
Ciao,
Mathias
Reply to: