Bug#378226: ITP: flickrfs
Varun Hiremath wrote:
Hi Alan,
On 11/6/06, *Alan Woodland* <awoodland@debian.org
<mailto:awoodland@debian.org>> wrote:
Co maintaining sounds like a good approach - I did have packages
almost
ready quite some time back, but there were a few python related issues
that needed fixing at the time. Do you have a key in the Debian
keyring
for making uploads? I can make uploads on your behalf as well as
co-maintaining if need be.
I am not a DD yet, so I can not make uploads. If you could upload
it on my behalf, I will be more than happy. If you want, you may add
yourself as Uploaders and co maintain this package with me.
That sounds agreeable to me.
I've just had a quick look over the .diff.gz - it is rather large! I
think this may be because a text editor or some other program has
altered the indentation style of several of the files? Any chance of
sorting that, it makes reviewing the package a lot easier :-)
I have made some changes and uploaded the files again to
http://varun.travisbsd.org/debian_packages/flickrfs/ This time I have
included a brief manpage also.
Thanks for fixing the .diff.gz. Much more readable now :-)
I've had another quick look, and I've got a few comments:
Firstly you say "Architecture: any". Did you really mean this? I think
this should be ok as an "Architecture: all" package, since nothing
changes between any two architectures? If this is the case then using
all instead of any saves archive space, and buildd time.
Secondly your manpage points people to documentation on the internet.
Some people might complain about this. Although as flickrfs is an online
tool, this complaint is somewhat reduced it may still be worth including
an offline copy of the documentation with the package. Additionally the
manpage doesn't actually say anything more than the long description
does really. Can you add some more precise documentation about how to
get started using it there? How to mount the filesystem or configure it?
Thirdly I'm not massively keen on the long description as it stands. See
the long description in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=378226 and the
associated comments on it.
Fourthly your copyright file states:
It was downloaded from <http://varun.travisbsd.org/debian_packages/flickrfs/>
This should be the URL for the original version, e.g. in this case http://manishrjain.googlepages.com/flickrfs
Finally I think the package should recommend imagemagick, and possibly (although I'm not 100% sure) depend on fuse-utils.
Other than that things seem in order as far as I can see.
Alan
Reply to: