[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#300464: RFS: phpicalendar -- clean, logical iCalendar web interface



On Apr 23, 2005, at 7:46 AM, Andreas Barth wrote:
* ms419@freezone.co.uk (ms419@freezone.co.uk) [050412 08:00]:
On Apr 11, 2005, at 3:09 AM, Andreas Barth wrote:
* ms419@freezone.co.uk (ms419@freezone.co.uk) [050411 04:10]:
Both Chad & I really look forward to making this package part of
Debian

Actually, I would really like to sponsor this package.

Hello Andi - I updated the phpicalendar package -
http://cgi.sfu.ca/~jdbates/debian/pool/phpicalendar/

Will you still consider sponsoring this package?

Quite better. Some (fewer) comments:

- prerm removes the apache-config-file even on upgrade - this leads to
loosing configuraion on each upgrade. Please consider to just kill the
  configuration on purge

prerm removes links to /etc/phpicalendar/apache.conf if they were automatically created by postinst. Since /etc/phpicalendar/apache.conf is a config file, configuration should be preserved

- similarly, postinst installs he configuration even if the
  administrator has previously killed it by hand.

Tricky. You are correct - I considered how to detect if the administrator manually removes links to /etc/phpicalendar/apache.conf

At least postinst only installs links for servers debconf is set to automatically configure. The administrator could use "dpkg-reconfigure phpicalendar" to kill automatic configuration now & for always

It should also be trivial for prerm to detect if a link is manually removed & update debconf accordingly. If you like this, I will make it so

- the construct
  [ -d  /etc/$server/conf.d/ -a ! -e /etc/$server/conf.d/phpicalendar ]
  in postinst is not posix - please use [ -d ...] && [ ...]

Thank you for your attention - done

- Perhaps add an hint about the posibility to publish via the
  php-scripts - and that this is disabled by default

Hints added to REAME.Debian

- I'm not sure if the default should not rather be to anonymously read
  icalendar files instead of requiring ftp-authentication - but that is
  your call as maintainer. However, adding some information about the
  different authentication possibilities to README.Debian might be a
  good idea.

By default, authentication is not required. The administrator should configure webserver authentication before enabling publishing. Please let me know if you encounter ftp-authentication by default, since I encounter different behavior

Thanks Andi! - Jack

Attachment: signature.asc
Description: Digital signature


Reply to: