[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#300464: RFS: phpicalendar -- clean, logical iCal/vCalendar web interface

* ms419@freezone.co.uk (ms419@freezone.co.uk) [050412 08:00]:
> On Apr 11, 2005, at 3:09 AM, Andreas Barth wrote:
> >Hi,
> >
> >* ms419@freezone.co.uk (ms419@freezone.co.uk) [050411 04:10]:
> >>Both Chad & I really look forward to making this package part of 
> >>Debian
> >>- please consider sponsoring it : )
> >
> >Actually, I would really like to sponsor this package. However, on a
> >first review, I'm a bit uncertain about the following bits:
> >
> >* Many lintian errors (please run lintian by yourself to see them :)
> >* apache doesn't need to be restarted, reloading is enough
> >* I'm not sure why you need to ask so many questions - isn't it enough
> >  to ask about reloading of the servers once? Most people don't have
> >  such complicated setups.

> Thanks so much for your interest & your feedback!
> Lucas Wall also expressed interest in sponsoring this package - I made 
> all the helpful corrections I received & built a new package - 
> http://cgi.sfu.ca/~jdbates/debian/pool/phpicalendar/
> What do you think?

Quite better. Some (fewer) comments:

- prerm removes the apache-config-file even on upgrade - this leads to
  loosing configuraion on each upgrade. Please consider to just kill the
  configuration on purge
- similarly, postinst installs he configuration even if the
  administrator has previously killed it by hand.
- the construct 
  [ -d  /etc/$server/conf.d/ -a ! -e /etc/$server/conf.d/phpicalendar ]
  in postinst is not posix - please use [ -d ...] && [ ...]
- Perhaps add an hint about the posibility to publish via the
  php-scripts - and that this is disabled by default
- I'm not sure if the default should not rather be to anonymously read
  icalendar files instead of requiring ftp-authentication - but that is
  your call as maintainer. However, adding some information about the
  different authentication possibilities to README.Debian might be a
  good idea.

Thanks for your work.

   PGP 1024/89FB5CE5  DC F1 85 6D A6 45 9C 0F  3B BE F1 D0 C5 D1 D9 0C

Reply to: