[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#872643: marked as done (openssh: Please quote IP address in suggested "ssh-keygen -f" calls)



Your message dated Wed, 23 Aug 2017 01:05:54 +0000
with message-id <E1dkK7G-0005HF-Hm@fasolo.debian.org>
and subject line Bug#872643: fixed in openssh 1:7.5p1-6
has caused the Debian Bug report #872643,
regarding openssh: Please quote IP address in suggested "ssh-keygen -f" calls
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
872643: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=872643
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: openssh
Version: 1:7.5p1-5
Severity: wishlist
Tags: patch

Hi,

I was just removing an entry in my known_hosts file with the following:

  ssh-keygen -f "/home/lamby/.ssh/known_hosts" -R [177.220.10.134]:22050

However, my shell is "too smart" and tries to clever things with the
square brackets in the IP address.

I just quoted this bit too, resulting in:

  ssh-keygen -f "/home/lamby/.ssh/known_hosts" -R "[177.220.10.134]:22050"

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
diff --git a/debian/patches/mention-ssh-keygen-on-keychange.patch b/debian/patches/mention-ssh-keygen-on-keychange.patch
index f2274cb..695316c 100644
--- a/debian/patches/mention-ssh-keygen-on-keychange.patch
+++ b/debian/patches/mention-ssh-keygen-on-keychange.patch
@@ -25,7 +25,7 @@ index 7f169a8f..66c495f4 100644
  				error("Offending key for IP in %s:%lu",
  				    ip_found->file, ip_found->line);
 +				error("  remove with:");
-+				error("  ssh-keygen -f \"%s\" -R %s",
++				error("  ssh-keygen -f \"%s\" -R \"%s\"",
 +				    ip_found->file, ip);
 +			}
  		}
@@ -36,7 +36,7 @@ index 7f169a8f..66c495f4 100644
  		error("Offending %s key in %s:%lu", key_type(host_found->key),
  		    host_found->file, host_found->line);
 +		error("  remove with:");
-+		error("  ssh-keygen -f \"%s\" -R %s", host_found->file, host);
++		error("  ssh-keygen -f \"%s\" -R \"%s\"", host_found->file, host);
  
  		/*
  		 * If strict host key checking is in use, the user will have

--- End Message ---
--- Begin Message ---
Source: openssh
Source-Version: 1:7.5p1-6

We believe that the bug you reported is fixed in the latest version of
openssh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 872643@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated openssh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 23 Aug 2017 01:41:06 +0100
Source: openssh
Binary: openssh-client openssh-client-ssh1 openssh-server openssh-sftp-server ssh ssh-krb5 ssh-askpass-gnome openssh-client-udeb openssh-server-udeb
Architecture: source
Version: 1:7.5p1-6
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenSSH Maintainers <debian-ssh@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 openssh-client - secure shell (SSH) client, for secure access to remote machines
 openssh-client-ssh1 - secure shell (SSH) client for legacy SSH1 protocol
 openssh-client-udeb - secure shell client for the Debian installer (udeb)
 openssh-server - secure shell (SSH) server, for secure access from remote machines
 openssh-server-udeb - secure shell server for the Debian installer (udeb)
 openssh-sftp-server - secure shell (SSH) sftp server module, for SFTP access from remot
 ssh        - secure shell client and server (metapackage)
 ssh-askpass-gnome - interactive X program to prompt users for a passphrase for ssh-ad
 ssh-krb5   - secure shell client and server (transitional package)
Closes: 864190 865770 872643 872851
Changes:
 openssh (1:7.5p1-6) unstable; urgency=medium
 .
   [ Colin Watson ]
   * Test configuration before starting or reloading sshd under systemd
     (closes: #865770).
   * Create /run/sshd under systemd using RuntimeDirectory rather than
     tmpfiles.d (thanks, Dmitry Smirnov; closes: #864190).
 .
   [ Dimitri John Ledkov ]
   * Drop upstart system and user jobs (closes: #872851).
 .
   [ Chris Lamb ]
   * Quote IP address in suggested "ssh-keygen -f" calls (closes: #872643).
Checksums-Sha1:
 6ea96b2b3987145f766ab585b3aebc5e2efb233c 2892 openssh_7.5p1-6.dsc
 8fbcb67cda70007785de2a9d1cba513dece03fdc 157968 openssh_7.5p1-6.debian.tar.xz
 b42972d6255ff7a4b2fc52a7cdb739ea1eedab02 13545 openssh_7.5p1-6_source.buildinfo
Checksums-Sha256:
 463f8e7dc1f012abd7b3264645991cd639e51f048e5c8e160969474017d2cd0f 2892 openssh_7.5p1-6.dsc
 6fa0418d8110b3527d217c9eaf6fbd1ef1c27e2bdbf58f057ebea5329781e6a9 157968 openssh_7.5p1-6.debian.tar.xz
 fd958956b8a38e555bfddb78891c9dcc21c04aba65a1f05e4976f140ec3120ae 13545 openssh_7.5p1-6_source.buildinfo
Files:
 4ba3c100b673e5ea7026655a594b476c 2892 net standard openssh_7.5p1-6.dsc
 19d714e835ea30de3664eff3e6dd03f8 157968 net standard openssh_7.5p1-6.debian.tar.xz
 cb7b9d8d6897999e84ae860fc85a3484 13545 net standard openssh_7.5p1-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAlmczz4ACgkQOTWH2X2G
UAvcLhAAkWt96N/RFRPW90woLT9PQsFzBTR+55IVgTo/1AJMEkgiZPteTARYz5/H
4HI/RW5E1TKNSIrola74d+tXhet/3ESgCxyKw1tOwExb8m/d/Sh1MFyokS/fT/o6
GNlCg5m0N4gkTNvlw8FrrQJD9096UKSN7/pZSxHQRWrobGSbJ67qi5t4LxnCYwQO
qPyL/WdkyoiBR4CC+FOoR+27wZ4HTyNrq63diqCf2s634mpGzdVbrfHQfg+UtfKg
+gjnFtJ+U9qwu/hTRy2egI+IuvENpqTWHdyGcWrOhIt0wxn1xJMw4ebUawT36zcs
VVPXmoV5hyv/qShcuQMFPQ7vWBFC91DTWzC1AMyUOvx6VV5zXMuvm76694eR84eW
UxAwx8ZbTw5L8iRj7g0BHp8LvouR06miZ4GSLKrYIxa4BeEuZ5RDmX2DSx8/OMxY
tSMcMkRdKJrWO53dhAZ6ly/I8xE95dv+Y+xVY6npVsxeTSea4nhPihI4aWDmv8/q
sfzlClJOfVio25qqU2UaMuIzy8gi1fiPCZgKyvUFM26hfz5WX1YOj/h6wS6iA8GA
aAky0oypxynIxSgID7jSLBR0N77ep3REFP54xLr0MTpxe39I5LtsMgO7Di1hd+jE
tsqVEtdA3cZ+oOIB1tLklLpfwR5YvH1q0G8ke6zHo34rBS6GvFo=
=4tCe
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: