Hi Vincent,
Thanks for the review.
On Sun, Jun 24, 2012 at 12:13:08AM +0200, Vincent Fourmond wrote:
> * first, you say you dropped the suggests on ruby-prawn
> ruby-nokogiri, but the latter still is referenced. BTW, why removing
> the suggests at all if they provide additional functionality ? I liked
> the way the old long description said things
The PDF formatter has been moved to another gem since version 1.2.
Cucumber does not need prawn any more. I left ruby-nokogiri in Suggests:
because it can be indeed useful, but it is (from what I understand) not
used at all by cucumber, and I think the old long description may be
misleading when it says that ruby-nokogiri _must_ be installed.
I updated the changelog by removing the fact I was removing the explicit
suggestion on ruby-nokogiri.
> * why do you include a copy of jquery.js in the package ? I fail to
> see the point, if it is available from libjs-jquery. If you have to
> have it available at build time, build-depend on libjs-jquery and make
> appropriate symlinks, if you can't go around having it in the build
> directory.
I am providing a non minified version of jsquery in debian as source for
the minified embedded copy. Minified javascript libraries are considered
by the ftpmasters as binary files, so they need source. Providing the
non-minified version in debian/ has been proved enough to content them
(see e.g yard or ruby-mocha).
I updated the changelog and copyright files to state this more clearly.
> And, just as a side note, please bump the dependency on gem2deb to
> (>= 0.3.0~) (see thread starting at
> http://lists.debian.org/debian-ruby/2012/06/msg00097.html).
I updated the dependency on gem2deb. Here is the new changelog entry:
cucumber (1.2.1-1) unstable; urgency=low
* New upstream version
* Use ruby-test.rake to run tests. Build-depend on rake.
* Bump Standards-Version: to 3.9.3 (no changes needed)
* Add 003-Disable-tests-assuming-ordered-hashes.patch
+ disable tests relying on ordered hashes
* Add myself to Uploaders:
* Depend on libjs-jquery instead of using the embedded copy.
+ include non-minified copy of jquery as source of the embedded version
+ update copyright file to take into account jsquery
* Do no suggest anymore ruby-prawn
* Bump dependency of gem2deb to version >= 0.3.0
-- Cédric Boutillier <cedric.boutillier@gmail.com> Fri, 22 Jun 2012 01:02:55 +0200
Best wishes,
Cédric
Attachment:
signature.asc
Description: Digital signature