Bug#1043268: libnetfilter-conntrack: please disable documentation build when not building libnetfilter-conntrack-doc

[Simon McVittie <smcv@debian.org>]

Source: libnetfilter-conntrack
Version: 1.0.9-3
Severity: wishlist
Tags: patch
X-Debbugs-Cc: debian-riscv@lists.debian.org

The riscv64 port is currently being bootstrapped, and I noticed that
packages like gtk4 are currently unbuildable because they are waiting
for src:systemd. Looking at the dependency chain for src:systemd,
it indirectly depends on libnetfilter-conntrack, which is currently
unbuildable because of a long dependency chain starting with graphviz
(and ending at abseil, which takes a long time to build on riscv64 and
failed several times with timeouts).

libnetfilter-conntrack only needs graphviz (and doxygen) for its API
documentation, so an easy way to break this dependency chain would be
for libnetfilter-conntrack to only build its API documentation when
"Architecture: all" packages are being built. A side benefit is that
this would make official builds by the buildds a bit faster.

Please consider applying the attached patch, with the "Closes" line
amended to mention this bug report's bug number. I used diffoscope to
confirm that this change does not alter the contents of either the _amd64
or _all binary packages.

Thanks,
    smcv

>From 962990823787cb3cf795106238e9d5d6db5e8b41 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Tue, 8 Aug 2023 09:28:35 +0100
Subject: [PATCH] d/control, d/rules: Only build API documentation if we need
 it

When only building the architecture-specific packages, as the buildds do,
we won't produce libnetfilter-conntrack-doc and therefore we don't need
to run doxygen.

Closes: -1
---
 debian/control | 4 ++--
 debian/rules   | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/debian/control b/debian/control
index d5821ef..f3f0599 100644
--- a/debian/control
+++ b/debian/control
@@ -6,12 +6,12 @@ Uploaders: Alexander Wirt <formorer@debian.org>,
            Arturo Borrero Gonzalez <arturo@debian.org>,
            Jeremy Sowden <jeremy@azazel.net>
 Build-Depends: debhelper-compat (= 13),
-               doxygen,
-               graphviz,
                libmnl-dev,
                libnfnetlink-dev,
                libtool,
                pkg-config
+Build-Depends-Indep: doxygen,
+                     graphviz
 Standards-Version: 4.6.2
 Rules-Requires-Root: no
 Homepage: https://www.netfilter.org/projects/libnetfilter_conntrack/
diff --git a/debian/rules b/debian/rules
index 16a3bb6..2a25b68 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,6 +6,5 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 %:
 	dh $@
 
-override_dh_auto_build:
-	dh_auto_build
+execute_after_dh_auto_build-indep:
 	doxygen doxygen.cfg
-- 
2.40.1