Bug#1098488: freerdp3-x11: Enable fdk-aac to replace buggy aac encoder from ffmpeg

[akallabeth <akallabeth+debian@posteo.net>]

ok, since the fdk-aac thing does not look like it is an option I did 
have a more detailed look at the issue on the ffmpeg side.

created https://github.com/FreeRDP/FreeRDP/pull/11225 which seems to 
work fine (just ignore errors from the encoder)

tried to have a look into the library, but something seems to be wrong 
there as the encoder state. That is what causes the error while the 
return code blames the data provided.


regards


On 21.02.25 13:57, Jeremy Bícha wrote:
> On Fri, Feb 21, 2025 at 4:27 AM akallabeth <akallabeth+debian@posteo.net> wrote:
> > Upstream FreeRDP also supports the fdk-aac encoder which can be enabled with
> > -DWITH_FDK_AAC=ON during build.
> > Since this dependency is also in the repo it would be preferrable to have this
> > working AAC encoder compiled in instead of one bailing out on some input data.
>
> fdk-aac is in non-free. By Debian Policy, we cannot have packages in
> Debian main depend on it.
>
> I tried to get fdk-aac-free into Debian main but it was rejected last
> year and I haven't had the spare time or energy to try to appeal that
> decision. [1]
>
> [1] https://lists.debian.org/debian-multimedia/2024/07/msg00265.html
>
> Beyond freerdp, I know that gnome-remote-desktop, gst-plugins-bad1.0
> and pipewire would also like to use fdk-aac.
>
> In Ubuntu, the Ubuntu Security Team rejected my attempt to use
> fdk-aac-free for the default Ubuntu install.
> https://launchpad.net/bugs/1977614
>
> Thank you,
> Jeremy Bícha