[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1019724: Processed: tagging 1019724



Control: tags -1 + pending

El 20/10/22 a las 17:58, Adrian Bunk escribió:
> On Thu, Oct 20, 2022 at 04:17:18PM +0200, Santiago Ruano Rincón wrote:
> > El 20/10/22 a las 11:30, Debian Bug Tracking System escribió:
> > > Processing commands for control@bugs.debian.org:
> > > 
> > > > tags 1019724 + ftbfs
> > > Bug #1019724 [grep] warning: stray \ before - causes autopkgtest failure
> > > Added tag(s) ftbfs.
> > 
> > Could you please clarify why it FTBFS? The warnings are present during
> > the build process, but I can build grep on a clean environment.
> 
> It makes another package FTBFS, with the affects and the ftbfs tag this 
> bug is displayed at
>   https://buildd.debian.org/status/package.php?p=kbuild

I am kind of surprised kbuild fails to build *now*. Lucas has run an
archive rebuild and he didn't report any package failing to build.

Please note this warning comes from an erroneous search pattern, and is
that pattern that should be fixed. In this case, grep has fixed its
behaviour.
Anyway, I am planing to apply the attached patch to temporarily disable
the warning by default.

Cheers,

 -- Santiago
Description: Temporarily disable the stray \ warnings. While the related
  patters are wrong, these warnings are causing trouble in Debian package
  builds and autopkgtests.
  This patch should be removed after coordination with the rest of the project
  to remove the erroneous patterns.
  Setting the DEBIAN_GREP_ENABLE_STRAY_BACKSLASH_WARN environement variable
  restores the upstream beahviour, enabling the warning.
Author: Santiago Ruano Rincón <santiago@debian.org>
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019724

Index: grep/lib/dfa.c
===================================================================
--- grep.orig/lib/dfa.c
+++ grep/lib/dfa.c
@@ -1547,7 +1547,10 @@ lex (struct dfa *dfa)
           if (!backslash)
             goto normal_char;
         stray_backslash:
-          if (dfa->syntax.dfaopts & DFA_STRAY_BACKSLASH_WARN)
+          char const *userevalwarn;
+          userevalwarn = getenv ("DEBIAN_GREP_ENABLE_STRAY_BACKSLASH_WARN");
+          if ((dfa->syntax.dfaopts & DFA_STRAY_BACKSLASH_WARN) &&
+              !(userevalwarn == NULL || *userevalwarn == '\0'))
             {
               char const *msg;
               char msgbuf[100];

Attachment: signature.asc
Description: PGP signature


Reply to: