[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#988459: unblock: digimend-dkms/10-3



Control: tags -1 moreinfo

On 2021-05-13 21:02:36 +0900, Kentaro Hayashi wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: kenhys@xdump.org
> 
> Please unblock package digimend-dkms
> 
> [ Reason ]
> 
> If bullseye user installed digimend-dkms/10-2, some of them hits the
> following FTBFS issue. [1]
> 
> It makes digimend-dkms unusable without fixed package.
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988134
> 
> [ Impact ]
> 
> After bullseye has been released without this fix, bullseye user hits
> a FTBFS issue already mentioned above [1] if appropriate linux-headers
> package is not installed. It can be avoided by installing linux-headers
> package in beforehand, but it is tedious.
> 
> [ Tests ]
> 
> I only tested the package manually.
> In the future updates (not this unblock request), it should be autopkgtest ready.
> 
> [ Risks ]
> 
> No risks for other packages because there is no reverse dependency
> from digimend-dkms.
> 
> [ Checklist ]
>   [x] all changes are documented in the d/changelog
>   [x] I reviewed all changes and I approve them
>   [x] attach debdiff against the package in testing
> 
> [ Other info ]
> 
> N/A
> 
> unblock digimend-dkms/10-3


diff -Nru digimend-dkms-10/debian/changelog digimend-dkms-10/debian/changelog
--- digimend-dkms-10/debian/changelog	2021-02-06 14:08:36.000000000 +0900
+++ digimend-dkms-10/debian/changelog	2021-05-11 13:30:01.000000000 +0900
@@ -1,3 +1,10 @@
+digimend-dkms (10-3) unstable; urgency=medium
+
+  * debian/control
+    - Add missing Depends: (Closes: #988134)
+
+ -- Kentaro Hayashi <kenhys@xdump.org>  Tue, 11 May 2021 13:30:01 +0900
+
 digimend-dkms (10-2) unstable; urgency=medium
 
   * Source only upload for migration to testing
diff -Nru digimend-dkms-10/debian/control digimend-dkms-10/debian/control
--- digimend-dkms-10/debian/control	2021-02-06 14:08:36.000000000 +0900
+++ digimend-dkms-10/debian/control	2021-05-11 13:30:01.000000000 +0900
@@ -12,8 +12,11 @@
 Rules-Requires-Root: no
 
 Package: digimend-dkms
-Architecture: all
-Depends: ${misc:Depends}, xserver-xorg-input-wacom
+Architecture: amd64

Is this package not useful on other architectures?

+Depends:
+ ${misc:Depends},
+ linux-headers-amd64,

This is counter the established practice of -dkms packages. The dkms
package recommends the header meta packages already, but there is
nothing more you can do. For all installed kernels you want the module
to be built, also the headers are required. A dependency on
linux-headers-amd64 does not guarantee that headers for all installed
kernels are available. I would suggest to close the bug report as
wontfix and revert this change.

Cheers
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


Reply to: