Bug#987311: unblock: pgpool2/4.1.4-3
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package pgpool2.
[ Reason ]
The new version fixes a bug which prevents the counter of open
connection from being reduced when a query is canceled.
[ Impact ]
If the bug is not fixed, connection pools will become unavailable.
[ Tests ]
The package passes the "jdbc" smoke tests exercising a connection
through the pool. (The upstream test system is unfortunately quite
involved and doesn't easily run at build time.)
[ Risks ]
The fix is a trivial one-liner.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
unblock pgpool2/4.1.4-3
Christoph
No differences were encountered between the control files
diff -Nru pgpool2-4.1.4/debian/changelog pgpool2-4.1.4/debian/changelog
--- pgpool2-4.1.4/debian/changelog 2020-10-09 16:48:13.000000000 +0200
+++ pgpool2-4.1.4/debian/changelog 2021-04-19 17:43:35.000000000 +0200
@@ -1,3 +1,10 @@
+pgpool2 (4.1.4-3) unstable; urgency=medium
+
+ * Fix connection count when query is canceled. (Closes: #987183,
+ upstream #656, git 6d6e4cc3).
+
+ -- Christoph Berg <myon@debian.org> Mon, 19 Apr 2021 17:43:35 +0200
+
pgpool2 (4.1.4-2) unstable; urgency=medium
* Bump test-dependency on pg-common for `pg_buildext psql`.
diff -Nru pgpool2-4.1.4/debian/patches/987183 pgpool2-4.1.4/debian/patches/987183
--- pgpool2-4.1.4/debian/patches/987183 1970-01-01 01:00:00.000000000 +0100
+++ pgpool2-4.1.4/debian/patches/987183 2021-04-19 17:42:41.000000000 +0200
@@ -0,0 +1,25 @@
+From: Tatsuo Ishii <ishii@sraoss.co.jp>
+Date: Thu, 29 Oct 2020 20:59:23 +0000 (+0900)
+Subject: Fix connection count when query is canceled.
+X-Git-Tag: V4_1_5~5
+X-Git-Url: http://git.postgresql.org/gitweb/?p=pgpool2.git;a=commitdiff_plain;h=6d6e4cc3d7ce0cdfcf9b2b6ea3ac5dc04b366aec
+
+Fix connection count when query is canceled.
+
+Connection counter was not counted down when a query is canceled.
+
+Per bug 656.
+---
+
+diff --git a/src/protocol/child.c b/src/protocol/child.c
+index af1dd50b..47482f61 100644
+--- a/src/protocol/child.c
++++ b/src/protocol/child.c
+@@ -2302,6 +2302,7 @@ retry_startup:
+ {
+ cancel_request((CancelPacket *) sp->startup_packet);
+ pool_free_startup_packet(sp);
++ connection_count_down();
+ return NULL;
+ }
+
diff -Nru pgpool2-4.1.4/debian/patches/series pgpool2-4.1.4/debian/patches/series
--- pgpool2-4.1.4/debian/patches/series 2020-10-06 15:42:58.000000000 +0200
+++ pgpool2-4.1.4/debian/patches/series 2021-04-19 17:42:41.000000000 +0200
@@ -1,2 +1,3 @@
pgpool2-debian-config.patch
sbin-paths
+987183
Reply to: