[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#790060: jessie-pu: nbd update?



On Tue, 2015-07-14 at 22:40 +0200, Wouter Verhelst wrote:
> On Tue, Jul 14, 2015 at 08:21:02PM +0100, Adam D. Barratt wrote:
> > Control: tags -1 + moreinfo
> > 
> > On Fri, 2015-06-26 at 19:07 +0200, Wouter Verhelst wrote:
> > > #785727 describes a regression in the version of nbd-server in jessie
> > > wrt the one in wheezy, related to the "allow" configuration file. It's
> > > not a security-related bug (as it disallows more than it should), but
> > > it's still a problem.
[...]
> > > Is this something that would warrant a stable update?
> > 
> > Potentially, but a) the metadata for #785727 implies that the bug
> > currently affects the version of nbd in unstable, which would need
> > resolving first
> 
> Only because I'm lazy and didn't fix the metadata; the bug does not actually
> affect unstable, and the patch that's sent to the bug in
> <20150601152240.GC9268@lemon.iwr.uni-heidelberg.de> came from the 3.8..3.9 git
> history. I just updated the metadata.

Ok, thanks.

> > and b) we'd want to see a full debdiff for a package
> > built and tested on jessie in order to confirm.
> 
> Okay, I'll work on that then.

I see that it's been uploaded already. By "see ... in order to confirm"
I meant "before upload"; apologies if that wasn't clear.

Looking at the diff that was uploaded, I do have a few questions I'm
afraid:

ChangeLog                |   91 ++++++
 Makefile.in              |    4 
 doc/proto.html           |  515 +++++++++++++++++++++++++++++++++++++
 doc/proto.markdown       |  565 +++++++++++++++++++++++++++++++++++++++++
 gznbd/Makefile.in        |  641 +++++++++++++++++++++++++++++++++++++++++++++++
 libcliserv.la            |   41 +++
 man/nbd-server.1.sh.in   |    5 
 man/nbd-server.5.sh.in   |  105 ++++---
 nbd-3.8/debian/changelog |    7 
 nbdsrv.c                 |   17 -
 nbdsrv.h                 |    5 
 tests/code/clientacl.c   |    2 

That's much bigger than I was expecting given your description, and I'm
not sure all of the changes were intended to be included.

For instance, the Changelog diff includes the release of 3.11,
doc/proto.{html,markdown} are completely new, man/nbd-server.1.sh.in
mentions a new(?) option and man/nbd-server.5.sh.in describes a
behaviour change in nbd 3.10.

Regards,

Adam


Reply to: