[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#687928: marked as done (unblock: ocfs2-tools/1.6.4-1+deb7u1)

Your message dated Mon, 17 Sep 2012 13:33:55 +0100
with message-id <6bd79f80e1595fe43f398f13b5498dc6@mail.adsl.funky-badger.org>
and subject line Re: Bug#687928: unblock: ocfs2-tools/1.6.4-1+deb7u1
has caused the Debian Bug report #687928,
regarding unblock: ocfs2-tools/1.6.4-1+deb7u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
687928: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687928
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package ocfs2-tools

The proposed update of ocfs2-tools fixes RC bug #682517
(inability to launch the ocfs2console GUI):

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682517

The fix (thanks Sébastien Villemot) is straight-forward: drop a bad
Debian/Ubuntu specific patch, as can be seen from the attached debdiff.

I had originaly uploaded 1.6.4-2 straight to unstable and Adam D. Barratt had
unblocked it but corosync and redhat-cluster are preventing a migration to
testing. At his request I have therefore re-uploaded it to
testing-proposed-updates.

unblock ocfs2-tools/1.6.4-1+deb7u1

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

diff -Nru ocfs2-tools-1.6.4/debian/changelog ocfs2-tools-1.6.4/debian/changelog
--- ocfs2-tools-1.6.4/debian/changelog	2012-04-18 09:16:36.000000000 +0200
+++ ocfs2-tools-1.6.4/debian/changelog	2012-09-17 08:45:11.000000000 +0200
@@ -1,3 +1,10 @@
+ocfs2-tools (1.6.4-1+deb7u1) testing-proposed-updates; urgency=low
+
+  * Remove popen2-ignore-depreciation-warn.patch: it has the opposite effect,
+    turning deprecation warnings into errors (Closes: #682517, LP: #923754).
+
+ -- Jeremy Lainé <jeremy.laine@m4x.org>  Mon, 17 Sep 2012 08:44:57 +0200
+
 ocfs2-tools (1.6.4-1) unstable; urgency=low
 
   * New upstream release.  Closes: #669023.
diff -Nru ocfs2-tools-1.6.4/debian/patches/popen2-ignore-depreciation-warn.patch ocfs2-tools-1.6.4/debian/patches/popen2-ignore-depreciation-warn.patch
--- ocfs2-tools-1.6.4/debian/patches/popen2-ignore-depreciation-warn.patch	2011-03-25 16:48:30.000000000 +0100
+++ ocfs2-tools-1.6.4/debian/patches/popen2-ignore-depreciation-warn.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,18 +0,0 @@
-Description: Ignore the depreciation warning that popen2 will raise when it is imported. 
- Pending conversion to subprocess module.
-Author: Dave Walker (Daviey) <DaveWalker@ubuntu.com>
-Bug: https://launchpad.net/bugs/655548
---- a/ocfs2console/ocfs2console
-+++ b/ocfs2console/ocfs2console
-@@ -13,6 +13,11 @@
- #
- import warnings
- warnings.filterwarnings("error")
-+
-+# Ignore the depreciation warning that popen2 will raise when it is imported.
-+# FIXME: Pending conversion to subprocess module.
-+warnings.simplefilter("ignore", DeprecationWarning)
-+
- try:
-     import gtk
- except Exception, e:
diff -Nru ocfs2-tools-1.6.4/debian/patches/series ocfs2-tools-1.6.4/debian/patches/series
--- ocfs2-tools-1.6.4/debian/patches/series	2012-04-18 09:02:42.000000000 +0200
+++ ocfs2-tools-1.6.4/debian/patches/series	2012-08-15 09:41:14.000000000 +0200
@@ -5,7 +5,6 @@
 shorten-manpage-lines.patch
 ld-no-add-needed.diff
 ld-as-needed.diff
-popen2-ignore-depreciation-warn.patch
 ocfs2-controld-pcmk-id.patch
 format-security.patch
 ocfs2-controld-headers.patch

--- End Message ---
--- Begin Message --- 
On 17.09.2012 09:36, Jeremy Laine wrote:

Please unblock package ocfs2-tools

The proposed update of ocfs2-tools fixes RC bug #682517
(inability to launch the ocfs2console GUI):

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682517

The fix (thanks Sébastien Villemot) is straight-forward: drop a bad
Debian/Ubuntu specific patch, as can be seen from the attached debdiff.
I had originaly uploaded 1.6.4-2 straight to unstable and Adam D. Barratt had unblocked it but corosync and redhat-cluster are preventing a migration to 
testing. At his request I have therefore re-uploaded it to
testing-proposed-updates.


Approve hint added; thanks.

Regards,

Adam

--- End Message ---
Reply to: