[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#687439: unblock: php-codecoverage/1.1.2+dfsg1-3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear release team,

I ask for a freeze exception for php-codecoverage/1.1.2+dfsg1-3

This upload introduces a patch to remove a call to a library that is not
included in the package due license issues: highcharts.js

Actually the package becomes unusable, so that is why i'm asking for an
unblock.

The bug [1]684280 have more information about it.

I'm attaching the debdiff of:
debdiff php-codecoverage_1.1.2+dfsg1-2.dsc  php-codecoverage_1.1.2
+dfsg1-3.dsc > php-codecoverage_1.1.2+dfsg1-2:1.1.2+dfsg1-3.diff

Thanks

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684280

-- 
Luis Uribe
http://eviled.org
diff -Nru php-codecoverage-1.1.2+dfsg1/debian/changelog php-codecoverage-1.1.2+dfsg1/debian/changelog
--- php-codecoverage-1.1.2+dfsg1/debian/changelog	2012-05-11 01:52:52.000000000 -0500
+++ php-codecoverage-1.1.2+dfsg1/debian/changelog	2012-09-10 08:51:41.000000000 -0500
@@ -1,3 +1,13 @@
+php-codecoverage (1.1.2+dfsg1-3) unstable; urgency=low
+
+  * debian/patches
+    - Adding remove_highcharts.diff to remove highcharts.js from html
+    generated report (Closes: #684280).
+  * README.Debian
+    - Adding file
+
+ -- Luis Uribe <acme@eviled.org>  Wed, 05 Sep 2012 13:37:45 -0500
+
 php-codecoverage (1.1.2+dfsg1-2) unstable; urgency=low
 
   * Correctly sets the copyright for YUI files.
diff -Nru php-codecoverage-1.1.2+dfsg1/debian/patches/0030-remove_highcharts.diff php-codecoverage-1.1.2+dfsg1/debian/patches/0030-remove_highcharts.diff
--- php-codecoverage-1.1.2+dfsg1/debian/patches/0030-remove_highcharts.diff	1969-12-31 19:00:00.000000000 -0500
+++ php-codecoverage-1.1.2+dfsg1/debian/patches/0030-remove_highcharts.diff	2012-09-10 08:51:41.000000000 -0500
@@ -0,0 +1,39 @@
+Description: Patch to remove highcharts.js from html report
+Author: Luis Uribe <acme@eviled.org>
+Index: php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML.php
+===================================================================
+--- php-codecoverage.orig/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML.php	2012-09-05 13:49:43.000000000 -0500
++++ php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML.php	2012-09-05 13:50:56.000000000 -0500
+@@ -196,7 +196,6 @@
+           'directory.png',
+           'file.png',
+           'glass.png',
+-          'highcharts.js',
+           'jquery.min.js',
+           'style.css',
+           'yahoo-dom-event.js'
+Index: php-codecoverage/package.xml
+===================================================================
+--- php-codecoverage.orig/package.xml	2012-09-05 13:50:56.000000000 -0500
++++ php-codecoverage/package.xml	2012-09-05 13:50:56.000000000 -0500
+@@ -74,7 +74,7 @@
+    <file baseinstalldir="/" md5sum="3924dbe26adf381c90446e629349f091" name="PHP/CodeCoverage/Report/Factory.php" role="php">
+     <tasks:replace from="@package_version@" to="version" type="package-info" />
+    </file>
+-   <file baseinstalldir="/" md5sum="e9739afbb4a6ed9839abae4e41bd28f1" name="PHP/CodeCoverage/Report/HTML.php" role="php">
++   <file baseinstalldir="/" md5sum="270c1160dfd8e1436249c894a9436e06" name="PHP/CodeCoverage/Report/HTML.php" role="php">
+     <tasks:replace from="@package_version@" to="version" type="package-info" />
+    </file>
+    <file baseinstalldir="/" md5sum="dca04a9f26e8ed0599298573e73232a0" name="PHP/CodeCoverage/Report/Node.php" role="php">
+Index: php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML/Renderer/Template/dashboard.html.dist
+===================================================================
+--- php-codecoverage.orig/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML/Renderer/Template/dashboard.html.dist	2012-09-05 13:50:51.000000000 -0500
++++ php-codecoverage/PHP_CodeCoverage-1.1.2/PHP/CodeCoverage/Report/HTML/Renderer/Template/dashboard.html.dist	2012-09-05 13:51:38.000000000 -0500
+@@ -5,7 +5,6 @@
+     <title>{title}</title>
+     <link rel="stylesheet" type="text/css" href="style.css">
+     <script src="jquery.min.js" type="text/javascript"></script>
+-    <script src="highcharts.js" type="text/javascript"></script>
+     <script type="text/javascript">
+     $(document).ready(function() {
+           var classCoverageDistribution = new Highcharts.Chart({
diff -Nru php-codecoverage-1.1.2+dfsg1/debian/patches/series php-codecoverage-1.1.2+dfsg1/debian/patches/series
--- php-codecoverage-1.1.2+dfsg1/debian/patches/series	2012-05-11 01:52:52.000000000 -0500
+++ php-codecoverage-1.1.2+dfsg1/debian/patches/series	2012-09-10 08:51:41.000000000 -0500
@@ -1,2 +1,3 @@
 0010-Removes-LICENSE-file-from-binary-package.patch
 0020-Removes-non-free-files-from-package.xml.patch
+0030-remove_highcharts.diff
diff -Nru php-codecoverage-1.1.2+dfsg1/debian/README.Debian php-codecoverage-1.1.2+dfsg1/debian/README.Debian
--- php-codecoverage-1.1.2+dfsg1/debian/README.Debian	1969-12-31 19:00:00.000000000 -0500
+++ php-codecoverage-1.1.2+dfsg1/debian/README.Debian	2012-09-10 08:51:41.000000000 -0500
@@ -0,0 +1,4 @@
+Because of licensing issues, highcharts.js has been removed from this package.
+This means that although the report called with '--coverage-html' is
+generated, it won't be using highcharts.js
+

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: