Bug#686641: marked as done (unblock: bsnes/0.088-4)
Your message dated Tue, 04 Sep 2012 19:47:34 +0100
with message-id <1346784454.25563.12.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#686641: unblock: bsnes/0.088-4
has caused the Debian Bug report #686641,
regarding unblock: bsnes/0.088-4
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
686641: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686641
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package bsnes
Update closes RC bug #684840 (FTBFS).
It's a workaround for a gcc bug, but I'm under the impression that gcc will not be updated soon.
unblock bsnes/0.088-4
Here is the debdiff:
diff -Nru bsnes-0.088/debian/changelog bsnes-0.088/debian/changelog
--- bsnes-0.088/debian/changelog 2012-05-11 13:31:08.000000000 +0200
+++ bsnes-0.088/debian/changelog 2012-09-04 01:57:13.000000000 +0200
@@ -1,3 +1,9 @@
+bsnes (0.088-4) unstable; urgency=low
+
+ * Add workaround for g++ bug PR c++/53821. (Closes: #684840)
+
+ -- Tobias Hansen <tobias.han@gmx.de> Tue, 04 Sep 2012 01:54:01 +0200
+
bsnes (0.088-3) unstable; urgency=low
* Add bsnes-purify to the bsnes package.
diff -Nru bsnes-0.088/debian/patches/gcc-pr53821-workaround.patch bsnes-0.088/debian/patches/gcc-pr53821-workaround.patch
--- bsnes-0.088/debian/patches/gcc-pr53821-workaround.patch 1970-01-01 01:00:00.000000000 +0100
+++ bsnes-0.088/debian/patches/gcc-pr53821-workaround.patch 2012-08-28 01:45:31.000000000 +0200
@@ -0,0 +1,15 @@
+Description: Work around gcc bug PR c++/53821
+ This bug is present in Wheezys gcc-4.7 4.7.1-2.
+ It is fixed in gcc-4.7 4.7.1-3.
+Author: Tobias Hansen <tobias.han@gmx.de>
+
+--- a/bsnes/nall/sort.hpp
++++ b/bsnes/nall/sort.hpp
+@@ -69,6 +69,7 @@
+ }
+
+ template<typename T>
++ inline
+ void sort(T list[], unsigned size) {
+ return sort(list, size, [](const T &l, const T &r) { return l < r; });
+ }
diff -Nru bsnes-0.088/debian/patches/series bsnes-0.088/debian/patches/series
--- bsnes-0.088/debian/patches/series 2012-05-10 14:25:37.000000000 +0200
+++ bsnes-0.088/debian/patches/series 2012-08-27 22:45:42.000000000 +0200
@@ -5,3 +5,4 @@
detect-endianness.patch
remove-march=native-build-flag.patch
fix-purify-header-removal-and-input.patch
+gcc-pr53821-workaround.patch
--- End Message ---
--- Begin Message ---
On Tue, 2012-09-04 at 20:42 +0200, Tobias Hansen wrote:
> On 09/04/12 20:35, Adam D. Barratt wrote:
> > On Tue, 2012-09-04 at 11:20 +0200, Tobias Hansen wrote:
> >> Please unblock package bsnes
> >>
> >> Update closes RC bug #684840 (FTBFS).
> >> It's a workaround for a gcc bug, but I'm under the impression that gcc
> >> will not be updated soon.
> > Actually, gcc-4.7 4.7.1-7 should migrate in tonight's britney run. I'm
> > assuming the change in bsnes is harmless in combination with a fixed gcc
> > though?
[..]
> Great, I never got answers when I asked on debian-gcc and in a bug
> report whether gcc will get updates. Originally, I wanted to wait some
> more, but I'm in the NM process and was told to bring my packages in
> shape. ;) Yes, the change is harmless.
Okay, thanks; unblocked.
Regards,
Adam
--- End Message ---
Reply to: