[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#686462: release.debian.org: unblock: ruby-pgplot/0.1.3-6



Control: tags -1 + moreinfo

On Sun, 2012-09-02 at 05:53 +0900, Youhei SASAKI wrote:
> I'll request you to unblock ruby-pgplot package, version 0.1.3-6
> 
>  - It will fix three FTBFS bugs:
>    - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=675390
>    - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682409
>    - http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685963

The version information suggests that only one of those actually affects
the package in testing; is that correct?  (I'm not sure from looking at
the reports if the other bugs actually exist in testing or were
introduced by later fixes.)

>  - Add X11, PNG support for users

Could you expand a little more on what this means, beyond the addition
of the build dependencies?  It sounds a little "new feature"ish, which
isn't really what we'd like during a freeze.

>  - Change source format 3.0, Copyright format 1.0

fwiw, the diff *doesn't* do the first of those.  (Which is good :-) ).

> I attached debdiff output from 0.1.3-2(in wheezy) to 0.1.3-6.
[...]
> -Build-Depends: debhelper (>= 7.0.50~), gem2deb, 
> - ruby-narray, rdtool, 
> - pgplot5, gfortran
> -Standards-Version: 3.9.2
> +Build-Depends: 
> + debhelper (>= 7.0.50~),
> + gem2deb,
> + ruby-narray,
> + pgplot5,
> + gfortran,
> + libx11-dev,
> + libpng12-dev,
> + gfortran-4.6

Why was rdtool removed?

[...]
> --- ruby-pgplot-0.1.3/debian/doc/index.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/index.html	2012-07-25 14:39:35.000000000 +0900
[...]
> --- ruby-pgplot-0.1.3/debian/doc/install.html.ja	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/install.html.ja	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/method.html.ja ruby-pgplot-0.1.3/debian/doc/method.html.ja
> --- ruby-pgplot-0.1.3/debian/doc/method.html.ja	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/method.html.ja	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/pgcont.html ruby-pgplot-0.1.3/debian/doc/pgcont.html
> --- ruby-pgplot-0.1.3/debian/doc/pgcont.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/pgcont.html	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/pghist.html ruby-pgplot-0.1.3/debian/doc/pghist.html
> --- ruby-pgplot-0.1.3/debian/doc/pghist.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/pghist.html	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/pgimag.html ruby-pgplot-0.1.3/debian/doc/pgimag.html
> --- ruby-pgplot-0.1.3/debian/doc/pgimag.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/pgimag.html	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/pgline.html ruby-pgplot-0.1.3/debian/doc/pgline.html
> --- ruby-pgplot-0.1.3/debian/doc/pgline.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/pgline.html	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/rbpg-ind.html ruby-pgplot-0.1.3/debian/doc/rbpg-ind.html
> --- ruby-pgplot-0.1.3/debian/doc/rbpg-ind.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/rbpg-ind.html	2012-07-25 14:39:35.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/trailer.html ruby-pgplot-0.1.3/debian/doc/trailer.html
> --- ruby-pgplot-0.1.3/debian/doc/trailer.html	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/trailer.html	2012-06-01 18:27:14.000000000 +0900
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/doc/tutorial-01.html.ja ruby-pgplot-0.1.3/debian/doc/tutorial-01.html.ja
> --- ruby-pgplot-0.1.3/debian/doc/tutorial-01.html.ja	1970-01-01 09:00:00.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/doc/tutorial-01.html.ja	2012-07-25 14:39:35.000000000 +0900

Why are these in debian/ ?  Their addition doesn't seem to be mentioned
in the changelog; the stanzas for two of the FTBFS are unhelpfully
undetailed, which makes it difficult to tie them up with the changes.

> diff -Nru ruby-pgplot-0.1.3/debian/ruby-pgplot.docs ruby-pgplot-0.1.3/debian/ruby-pgplot.docs
> --- ruby-pgplot-0.1.3/debian/ruby-pgplot.docs	2011-05-18 05:04:21.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/ruby-pgplot.docs	2012-07-25 14:40:47.000000000 +0900
> @@ -1,5 +1,5 @@
> -doc/*.html
> -doc/*.html.ja
> +debian/doc/*.html
> +debian/doc/*.html.ja
[...]
> diff -Nru ruby-pgplot-0.1.3/debian/rules ruby-pgplot-0.1.3/debian/rules
> --- ruby-pgplot-0.1.3/debian/rules	2011-05-18 05:04:21.000000000 +0900
> +++ ruby-pgplot-0.1.3/debian/rules	2012-09-01 18:51:18.000000000 +0900
[...]
> -	( cd doc && make )
> +#	( cd doc && make )
[...] 
> -	( cd doc && make clean )
> +#	( cd doc && make clean )

As earlier, what's the rationale for these changes?

Regards,

Adam


Reply to: