[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SRM] Update geneweb in lenny



The geneweb package has an historically piece of code in its postinst
script that deals for recursively fixing permissions and owners in the
/var/lib/geneweb directory (the place where genealogical databases
that are served by the main daemon are stored).

There might be work in the future to remove that code, but I recently
got a bug report (#559411, initially reported for Ubuntu) that showed
that this code is failing if database names contain spaces, thus
having the upgrade fail.

The bug is fixed in unstable but I would like to fix it in lenny
through s-p-u with the attached patch to the postinst script. Stable
release managers, objections?

PS: the IFS change alone is enough to fix the bug....but the proper
variable quoting certainly doesn't hurt.

-- 



--- tags/5.01-8/debian/geneweb.postinst	2009-08-06 07:59:11.000000000 +0200
+++ trunk/debian/geneweb.postinst	2009-12-20 17:07:15.000000000 +0100
@@ -169,22 +167,28 @@
 	#
 	# Thanks to Russell Sutherland for pointing this to me
 	# Bug: 179918
+	#
+	# Deal properly with database names that contain spaces
+	OLDIFS=${IFS}
+	IFS='
+'
 	for base in `find $GENEWEBDB -type d -name \*.gwb`
 	do
-	    chgrp $USERS_GROUP $base
-	    chmod g+w,g+s $base
+	    chgrp $USERS_GROUP "$base"
+	    chmod g+w,g+s "$base"
 	    # Fix files permissions. See #219779
 	    for file in `find $base -type f`
 	    do
-		chgrp $USERS_GROUP $file
-		chmod g+w $file
+		chgrp $USERS_GROUP "$file"
+		chmod g+w "$file"
 	    done
 	done
 	for imagedir in `find $GENEWEBDB/images -type d`
 	do
-	    chgrp $USERS_GROUP $imagedir
-	    chmod g+w,g+s $imagedir
+	    chgrp $USERS_GROUP "$imagedir"
+	    chmod g+w,g+s "$imagedir"
 	done
+	IFS=${OLDIFS}
 
 	# Values are read from debconf
 	# to update variables

Attachment: signature.asc
Description: Digital signature


Reply to: