[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1023941: kiconthemes FTCBFS: disables designer plugin



Source: kiconthemes
Version: 5.98.0-2
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs

kiconthemes fails to cross build from source, because the upstream
CMakeLists.txt forcefully disables building the designer plugin during
cross builds. I think this should be an option and it practically works.
I'm attaching a patch for your convenience.

Helmut
diff --minimal -Nru kiconthemes-5.98.0/debian/changelog kiconthemes-5.98.0/debian/changelog
--- kiconthemes-5.98.0/debian/changelog	2022-09-22 08:52:51.000000000 +0200
+++ kiconthemes-5.98.0/debian/changelog	2022-11-12 18:13:06.000000000 +0100
@@ -1,3 +1,10 @@
+kiconthemes (5.98.0-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Build designer plugin. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sat, 12 Nov 2022 18:13:06 +0100
+
 kiconthemes (5.98.0-2) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru kiconthemes-5.98.0/debian/patches/cross.patch kiconthemes-5.98.0/debian/patches/cross.patch
--- kiconthemes-5.98.0/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ kiconthemes-5.98.0/debian/patches/cross.patch	2022-11-12 18:12:32.000000000 +0100
@@ -0,0 +1,11 @@
+--- kiconthemes-5.98.0.orig/CMakeLists.txt
++++ kiconthemes-5.98.0/CMakeLists.txt
+@@ -31,7 +31,7 @@
+ option(BUILD_QCH "Build API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)" OFF)
+ add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)")
+ 
+-cmake_dependent_option(BUILD_DESIGNERPLUGIN "Build plugin for Qt Designer" ON "NOT CMAKE_CROSSCOMPILING" OFF)
++option(BUILD_DESIGNERPLUGIN "Build plugin for Qt Designer" "NOT CMAKE_CROSSCOMPILING")
+ add_feature_info(DESIGNERPLUGIN ${BUILD_DESIGNERPLUGIN} "Build plugin for Qt Designer")
+ 
+ ecm_setup_version(PROJECT
diff --minimal -Nru kiconthemes-5.98.0/debian/patches/series kiconthemes-5.98.0/debian/patches/series
--- kiconthemes-5.98.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ kiconthemes-5.98.0/debian/patches/series	2022-11-12 18:12:17.000000000 +0100
@@ -0,0 +1 @@
+cross.patch
diff --minimal -Nru kiconthemes-5.98.0/debian/rules kiconthemes-5.98.0/debian/rules
--- kiconthemes-5.98.0/debian/rules	2022-09-22 08:40:09.000000000 +0200
+++ kiconthemes-5.98.0/debian/rules	2022-11-12 18:12:45.000000000 +0100
@@ -7,7 +7,7 @@
 	dh $@
 
 override_dh_auto_configure:
-	dh_auto_configure -- -DBUILD_QCH=ON -DBUILD_TESTING=OFF
+	dh_auto_configure -- -DBUILD_QCH=ON -DBUILD_TESTING=OFF -DBUILD_DESIGNERPLUGIN=ON
 
 override_dh_auto_test:
 	# Disable dh_auto_test on build time

Reply to: