Control: tags -1 + patch fixed-upstream
Greetings,
After digging into the build log, the reoccurring pattern which
seems to be the root of all failures is that:
> model->hasChildren(parent)' returned FALSE
This looks to stem from src/mediaplaylistproxymodel.cpp, for
which the definition of the method is limited to:
bool MediaPlayListProxyModel::hasChildren(const QModelIndex &parent) const
{
return (!parent.isValid()) ? false : (rowCount() > 0);
}
Looking into later versions in upstream repository, the logic of
the method has changed to be the reverse; note the trimmed
exclamation mark before the parent.isValid:
bool MediaPlayListProxyModel::hasChildren(const QModelIndex &parent) const
{
return (parent.isValid()) ? false : (rowCount() > 0);
}
Actually there is a simple commit which does just that work of
reverting the logic[1]. Applying this change fixes the FTBFS on
my end. This can be applied now, or can be fixed later with a
newer upstream version.
[1]: https://invent.kde.org/multimedia/elisa/-/commit/0968c47a8bb5e0abf66fb6069d62efa14e6d9ae1
Have a nice day, :)
--
Étienne Mollier <emollier@emlwks999.eu>
Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
Sent from my alarm clock.
Attachment:
signature.asc
Description: PGP signature