[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#979454: knotifications: reduce Build-Depends



Source: knotifications
Version: 5.77.0-2
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

knotifications plays a role in a pile of dependency cycles relevant to
architecture bootstrap. Rather than working on cycles directly, I looked
into easily droppable Build-Depends and noticed that knotifications has
some:

 * dbus-x11 is only used during the test suite. It can be tagged
   <!nocheck>.
 * I couldn't find any usage of graphviz. I propose dropping it.
 * xauth and xvfb are used to wrap the test suite in debian rules. They
   can be tagged <!nocheck>.

A nocheck build with these dependencies disabled produces exactly the
same .debs as a build containing them. Please consider applying the
attached patch.

Helmut
diff --minimal -Nru knotifications-5.77.0/debian/changelog knotifications-5.77.0/debian/changelog
--- knotifications-5.77.0/debian/changelog	2020-12-22 02:33:35.000000000 +0100
+++ knotifications-5.77.0/debian/changelog	2021-01-06 18:57:03.000000000 +0100
@@ -1,3 +1,10 @@
+knotifications (5.77.0-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Reduce Build-Depends. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Wed, 06 Jan 2021 18:57:03 +0100
+
 knotifications (5.77.0-2) unstable; urgency=medium
 
   * Release to unstable.
diff --minimal -Nru knotifications-5.77.0/debian/control knotifications-5.77.0/debian/control
--- knotifications-5.77.0/debian/control	2020-12-22 02:31:16.000000000 +0100
+++ knotifications-5.77.0/debian/control	2021-01-06 18:56:49.000000000 +0100
@@ -5,11 +5,10 @@
 Uploaders: Maximiliano Curia <maxy@debian.org>,
            Norbert Preining <norbert@preining.info>,
 Build-Depends: cmake (>= 3.5~),
-               dbus-x11,
+               dbus-x11 <!nocheck>,
                debhelper-compat (= 13),
                doxygen,
                extra-cmake-modules (>= 5.77.0~),
-               graphviz,
                libdbusmenu-qt5-dev,
                libkf5config-dev (>= 5.77.0~),
                libkf5coreaddons-dev (>= 5.77.0~),
@@ -24,8 +23,8 @@
                qtbase5-dev (>= 5.13.0~),
                qttools5-dev (>= 5.4),
                qttools5-dev-tools (>= 5.4),
-               xauth,
-               xvfb,
+               xauth <!nocheck>,
+               xvfb <!nocheck>,
 Standards-Version: 4.5.1
 Homepage: https://invent.kde.org/frameworks/knotifications
 Vcs-Browser: https://salsa.debian.org/qt-kde-team/kde/knotifications

Reply to: