[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#819512: breeze: please make the build reproducible



Source: breeze 
Version: 4:5.4.3-1 
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

While working on the "reproducible builds" effort [1], we have noticed
that breeze could not be built reproducibly.

When processing translation files and using a non-UTF8 locale, grep
misdetects them as binary files and embeds the line: "Binary file
(standard input) matches"

The attached patch fixes this by telling grep to treat the input as
text. Once applied, breeze can be built reproducibly in our current
experimental framework.

 [1]: https://wiki.debian.org/ReproducibleBuilds

Regards,
-- 
Dhole
diff -Nru breeze-5.4.3/debian/changelog breeze-5.4.3/debian/changelog
--- breeze-5.4.3/debian/changelog	2015-12-01 11:46:09.000000000 +0100
+++ breeze-5.4.3/debian/changelog	2016-03-28 18:31:13.000000000 +0200
@@ -1,3 +1,10 @@
+breeze (4:5.4.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix misdetection as binary input in grep when LC_ALL=C
+
+ -- Eduard Sanou <dhole@openmailbox.org>  Mon, 28 Mar 2016 18:30:54 +0200
+
 breeze (4:5.4.3-1) unstable; urgency=medium
 
   * New upstream release (5.4.3).
diff -Nru breeze-5.4.3/debian/wrapperthemes.sh breeze-5.4.3/debian/wrapperthemes.sh
--- breeze-5.4.3/debian/wrapperthemes.sh	2015-12-01 11:46:09.000000000 +0100
+++ breeze-5.4.3/debian/wrapperthemes.sh	2016-03-29 19:51:30.000000000 +0200
@@ -13,7 +13,7 @@
 
     mkdir -p ${CURDIR}/debian/tmp${WRAPPERDIR}
     cd ${CURDIR}/debian/tmp${ICONDIR}
-    grep -v Inherits ${CURDIR}/debian/tmp${ICONDIR}/${theme}/index.theme > "$tmp"
+    grep -a -v Inherits ${CURDIR}/debian/tmp${ICONDIR}/${theme}/index.theme > "$tmp"
     echo "Inherits=${theme}" >> "$tmp"
     install -m 644 "$tmp" ${CURDIR}/debian/tmp${WRAPPERDIR}/${theme}.theme
     rm "$tmp"

Attachment: signature.asc
Description: PGP signature


Reply to: