Bug#646612: kdebase-workspace: patch for a KRunner-Iceweasel problem
Package: kdebase-workspace
Version: 4:4.6.5-3
Severity: normal
Tags: patch pending
Dear maintainer,
On my system KRunner could not open Iceweasel bookmarks.
KRunner can open Firefox bookmarks by default, the problem
is specific to Iceweasel. I've fixed the problem and I
believe that any standard Debian system is affected by the
same problem so that's why I'm sending you this patch.
Below is a more detailed description of the problem so
you can judge for yourself.
KRunner's bookmark plugin tries to detect which browser
is being used by default, by checking the KDE user
configuration. When it's trying to match Firefox it looks
for 'firefox' in the Exec/Executable field in the .desktop
file of the default browser. On Debian, this value is
'iceweasel' so KRunner effectively misses the browser.
The result is that KRunner does not find Iceweasel's
bookmarks.
Regards.
diff -Nru kdebase-workspace-4.6.5/debian/changelog kdebase-workspace-4.6.5/debian/changelog
--- kdebase-workspace-4.6.5/debian/changelog 2011-09-17 18:15:50.000000000 +0200
+++ kdebase-workspace-4.6.5/debian/changelog 2011-10-25 18:26:04.000000000 +0200
@@ -1,3 +1,11 @@
+kdebase-workspace (4:4.6.5-3.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * KRunner now detects Iceweasel bookmarks.
+ See debian/patches/krunner_iceweasel_bookmarks.diff
+
+ -- Guido Loupias <guidol@lavabit.com> Tue, 25 Oct 2011 18:24:39 +0200
+
kdebase-workspace (4:4.6.5-3) unstable; urgency=low
[ Pino Toscano ]
diff -Nru kdebase-workspace-4.6.5/debian/patches/krunner_iceweasel_bookmarks.diff kdebase-workspace-4.6.5/debian/patches/krunner_iceweasel_bookmarks.diff
--- kdebase-workspace-4.6.5/debian/patches/krunner_iceweasel_bookmarks.diff 1970-01-01 01:00:00.000000000 +0100
+++ kdebase-workspace-4.6.5/debian/patches/krunner_iceweasel_bookmarks.diff 2011-10-25 16:33:25.000000000 +0200
@@ -0,0 +1,16 @@
+Description: KRunner patch so it detects Iceweasel bookmarks
+Forwarded: not-needed
+Author: Guido Loupias <guidol@lavabit.com>
+Index: kdebase-workspace-4.6.5/plasma/generic/runners/bookmarks/bookmarksrunner.cpp
+===================================================================
+--- kdebase-workspace-4.6.5.orig/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 2011-10-25 16:30:17.000000000 +0200
++++ kdebase-workspace-4.6.5/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 2011-10-25 16:33:16.000000000 +0200
+@@ -460,7 +460,7 @@
+ }
+
+ //kDebug() << exec;
+- if (exec.contains("firefox", Qt::CaseInsensitive)) {
++ if (exec.contains("firefox", Qt::CaseInsensitive) || exec.contains("iceweasel", Qt::CaseInsensitive)) {
+ return Firefox;
+ } else if (exec.contains("opera", Qt::CaseInsensitive)) {
+ return Opera;
diff -Nru kdebase-workspace-4.6.5/debian/patches/series kdebase-workspace-4.6.5/debian/patches/series
--- kdebase-workspace-4.6.5/debian/patches/series 2011-09-17 18:15:29.000000000 +0200
+++ kdebase-workspace-4.6.5/debian/patches/series 2011-10-25 16:31:13.000000000 +0200
@@ -19,3 +19,4 @@
enable_dlrestrcitions.diff
kdm_vt_switching_on_kfreebsd.diff
kwin_avoid_deep_vector_copies.diff
+krunner_iceweasel_bookmarks.diff
Reply to: