Bug#1034102: UDD patches: incorrect handling of Forwarded?

[Lucas Nussbaum <lucas@debian.org>]

Hi Ross,

On 08/04/23 at 16:59 -0700, Ross Vandegrift wrote:
> Package: qa.debian.org
> Severity: normal
> X-Debbugs-Cc: rvandegrift@debian.org
> 
> Hello,
> 
> I think there are some issues with the Forwarded handling here:
>   https://udd.debian.org/patches.cgi?src=e17&version=0.25.4-2
> 
> DEP3 has this description for Forwarded:
> 
> > Any value other than "no" or "not-needed" means that the patch has been
> > forwarded upstream. Ideally the value is an URL proving that it has been
> > forwarded and where one can find more information about its inclusion status.
> > 
> > If the field is missing, its implicit value is "yes" if the "Bug" field is
> > present, otherwise it's "no". The field is really required only if the patch
> > is vendor specific, in that case its value should be "not-needed" to indicate
> > that the patch must not be forwarded upstream (whereas "no" simply means that
> > it has not yet been done).
> 
> The patch linked above is tagged Forwarded=yes - which is not ideal, but not
> invalid.  Looking for more info, I found that the html source has:
> 
> > <td><span class="prio_high" title="Forwarded=yes, but no Bug field">invalid</span></td>
> 
> This doesn't show up in firefox - was this was meant to go into the content
> of the span?

It works for me in firefox?

> And as far that error - to my reading, DEP3 doesn't require a Bug when
> Forwarded=yes.  Bug's presence or absence only changes the implicit value.
> 
> A note that Forwarded=yes without a Bug is not informative would be helpful. :)

There was a lengthy discussion in #1028503 about that.

Lucas