Bug#993500: Watch sould honor npm source

[Lucas Nussbaum <lucas@debian.org>]

Control: retitle -1 UDD/upstream: Watch should honor npm source

On 02/09/21 at 09:13 +0000, Bastien Roucariès wrote:
> Package: qa.debian.org
> Severity: minor
> 
> Dear Maintainer,
> 
> Node-resolve watch fail with:
>  uscan had problems while searching for a new upstream version:
> 
> unknown ctype nodejs
> 
> 
> Could we support ctype nodejs ?

So I looked into this, and don't understand what happens.

The watch file info comes from the UDD 'upstream' importer.

ullmann.debian.org uses devscripts 2.21.3+deb11u1, which should know
about ctypes according to devscripts' changelog.

However, running uscan manually on node-resolve's watch file gives:

$ HTTPS_CA_DIR=/etc/ssl/ca-global uscan --pasv --dehs --no-download --watchfile w --package node-resolve --upstream-version '1.22.1+~cs5.32.10'
<dehs>
uscan warn: unknown ctype nodejs
<package>node-resolve</package>
<debian-uversion>1.22.1</debian-uversion>
<debian-mangled-uversion>1.22.1</debian-mangled-uversion>
<upstream-version>1.22.1</upstream-version>
<upstream-url>https://github.com/browserify/resolve/archive/refs/tags/v1.22.1.tar.gz</upstream-url>
<status>up to date</status>
<warnings>unknown ctype nodejs</warnings>
</dehs>

Even more strange, tracing using strace shows that uscan opens
Devscripts/Uscan/Ctype/nodejs.pm:

$ HTTPS_CA_DIR=/etc/ssl/ca-global strace -f uscan --pasv --dehs --no-download --watchfile w --package node-resolve --upstream-version '1.22.1+~cs5.32.10' 2>&1 |grep open |grep -i devscripts
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Config.pm", O_RDONLY|O_CLOEXEC) = 4
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Output.pm", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Output.pm", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Config.pm", O_RDONLY|O_CLOEXEC) = 4
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/FindFiles.pm", O_RDONLY|O_CLOEXEC) = 4
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Versort.pm", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/WatchFile.pm", O_RDONLY|O_CLOEXEC) = 4
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Downloader.pm", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/CatchRedirections.pm", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Utils.pm", O_RDONLY|O_CLOEXEC) = 6
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Utils.pm", O_RDONLY|O_CLOEXEC) = 7
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/WatchLine.pm", O_RDONLY|O_CLOEXEC) = 5
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Keyring.pm", O_RDONLY|O_CLOEXEC) = 6
[pid 4176178] openat(AT_FDCWD, "/etc/devscripts.conf", O_RDONLY) = 3
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/http.pm", O_RDONLY|O_CLOEXEC) = 3
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/_xtp.pm", O_RDONLY|O_CLOEXEC) = 4
openat(AT_FDCWD, "/usr/share/perl5/Devscripts/Uscan/Ctype/nodejs.pm", O_RDONLY|O_CLOEXEC) = 3

I cannot reproduce the warning outside ullmann, with the same devscripts
version.

Lucas