[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756766: marked as done (tracker.debian.org: Browse all news on a package)

Your message dated Sun, 15 Nov 2015 22:20:43 +0100
with message-id <20151115212043.GA18202@home.ouaza.com>
and subject line Re: Bug#756766: Initial work-patch on this bug
has caused the Debian Bug report #756766,
regarding tracker.debian.org: Browse all news on a package
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
756766: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756766
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: tracker.debian.org
Version: 0.20140710
Severity: wishlist

As a Web user, I can browse all news regarding a package and access
the message which created a particular news, e.g.
http://packages.qa.debian.org/d/dpkg/news/ (Ticket migrated from
Trello: https://trello.com/c/duNhR7pO/)

Acceptance tests:

  If there are more than 30 (limit for the number of news displayed in
  the news panel) total news items, the rest can be accessed by using
  pagination links in the bottom of the news panel.

  If Javascript is enabled, the next page is loaded asynchronously and
  does not cause a page reload -- the items in the panel are repopulated
  once the data is loaded.

  If Javascript is disabled, clicking a page link loads a new page which
  displays the news items of the package
  (/:package_name/news/page/:page_number) and has the pagination element
  pointing to other available pages.

  There is a link in the heading of the news panel which leads to the
  first page (opened as a new page no matter if Javascript is running or
  not).

  A redirect exists from /:hash/:packagename/news/ to this first page of
  package news

--- End Message ---
--- Begin Message --- 
On Thu, 12 Nov 2015, Orestis Ioannou wrote:
> > 3/ the package news page does return the expected content for "?page=2"
> > just to ensure that pagination works and that we display something that
> > looks OK
> 
> Added a test, I am not sure though if that's what you were looking for..

Looks good, I would have tested that we get a news between the 30th and
60th most recent but your test seems OK.

I have merged your patch but did some refactorization on top of it. You
might want to have a look at it to see what else you could have done
better... :)

I deployed the result but I'm not very happy with the look of the
"Page 2" link at the bottom of the panel. We should probably rename
it into "More news..." and integrate it visually like a last list
item. Do you want to have a try at this?

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

--- End Message ---
Reply to: