[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#956291: BlockingQueue.h: virtual bool add() wrong parameter type



Package: libzthread-dev
Version: 2.3.2-8
Severity: important

Based from the `zthread` documentation the correct paramter for
Queue::add() should be 'const T& item' and not 'T item'.

As upstream does not responde to any reports a patch has already been
applied to FreeBSD for example. I think it would be the best to also
patch it on Debian.

A patch has been attached.

-- System Information:
Debian Release: 10.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.5.10-gentoo-x86_64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages libzthread-dev depends on:
ii  libzthread-2.3-2  2.3.2-8

libzthread-dev recommends no packages.

libzthread-dev suggests no packages.

-- no debconf information
--- usr/include/zthread/BlockingQueue.h.orig	2005-03-13 02:04:18 UTC
+++ usr/include/zthread/BlockingQueue.h
@@ -83,7 +83,7 @@ namespace ZThread {
       /**
        * @see Queue::add(const T& item, unsigned long timeout)
        */
-      virtual bool add(T item, unsigned long timeout) {
+      virtual bool add(const T& item, unsigned long timeout) {
 
         try {
 

Reply to: