Bug#782366: libcunit1-dev: pkg-config file is broken
Package: libcunit1-dev
Version: 2.1-2.dfsg-2
Severity: important
Tags: patch
Dear Maintainer,
The pkg-config file distributed with libcunit1-dev is broken:
1. it has no "Version" field, which makes pkg-config error-out:
$ pkg-config --libs cunit
Package 'cunit' has no Version: field
Fixing this only requires adding a "Version: 2.1" (or alike) field.
2. its "libdir" variable misses a "$" to expand "exec_prefix", leading
to a literal "{exec_prefix}":
$ pkg-config --libs cunit
-L\{exec_prefix\}/lib -lcunit
Fixing this is even easier, just add the missing "$":
libdir=${exec_prefix}/lib
After fixing these two issues, the pkg-config file seem to work nicely
-- to my limited cunit knowledge, all I needed was building something
using it.
Interestingly apparently the source file debian/cunit.pc contains the
issues, but what I can only assume is the upstream template,
cunit.pc.in, does not suffer from the issues.
Maybe simply distributing upstream's version would fix it, but note it
has a difference: it adds "/usr/include" to the search path, not
"/usr/include/CUnit". Presumably upstream expects users to list the
prefix "CUnit/" in their includes -- and the package I tried to build
did just that. If this is a problem, a patch could be added to add
both paths, keeping compatibility with both sides -- but as the current
pkg-config file in Debian does not work, I doubt it is a real problem.
Regards,
Colomban
-- System Information:
Debian Release: 8.0
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages libcunit1-dev depends on:
ii libcunit1 2.1-2.dfsg-2
libcunit1-dev recommends no packages.
Versions of packages libcunit1-dev suggests:
pn libcunit1-doc <none>
-- no debconf information
From: Colomban Wendling <ban@herbesfolles.org>
Date: Sat Apr 11 02:44:06 2015 +0200
Subject: Fix pkg-config file
diff -Nur cunit-2.1-2.dfsg.old/debian/cunit.pc cunit-2.1-2.dfsg/debian/cunit.pc
--- cunit-2.1-2.dfsg.old/debian/cunit.pc 2015-04-11 02:06:05.569044199 +0200
+++ cunit-2.1-2.dfsg/debian/cunit.pc 1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-prefix=/usr
-exec_prefix=${prefix}
-libdir={exec_prefix}/lib
-includedir=${prefix}/include/CUnit
-
-Name: CUnit
-Description: The C Unit Test Library
-Libs: -L${libdir} -lcunit
-CFlags: -I${includedir}
diff -Nur cunit-2.1-2.dfsg.old/debian/libcunit1-dev.install cunit-2.1-2.dfsg/debian/libcunit1-dev.install
--- cunit-2.1-2.dfsg.old/debian/libcunit1-dev.install 2015-04-11 02:06:05.569044199 +0200
+++ cunit-2.1-2.dfsg/debian/libcunit1-dev.install 2015-04-11 02:22:03.547971399 +0200
@@ -1,5 +1,5 @@
-debian/tmp-cunit/usr/include usr
-debian/tmp-cunit/usr/lib/lib*.a usr/lib
-debian/tmp-cunit/usr/lib/lib*.so usr/lib
-debian/tmp-cunit/usr/share/man/man3 usr/share/man
-debian/cunit.pc usr/lib/pkgconfig
+debian/tmp-cunit/usr/include usr
+debian/tmp-cunit/usr/lib/lib*.a usr/lib
+debian/tmp-cunit/usr/lib/lib*.so usr/lib
+debian/tmp-cunit/usr/share/man/man3 usr/share/man
+debian/tmp-cunit/usr/lib/pkgconfig/cunit.pc usr/lib/pkgconfig
diff -Nur cunit-2.1-2.dfsg.old/debian/libcunit1-ncurses-dev.install cunit-2.1-2.dfsg/debian/libcunit1-ncurses-dev.install
--- cunit-2.1-2.dfsg.old/debian/libcunit1-ncurses-dev.install 2015-04-11 02:06:05.569044199 +0200
+++ cunit-2.1-2.dfsg/debian/libcunit1-ncurses-dev.install 2015-04-11 02:21:32.620005868 +0200
@@ -1,5 +1,5 @@
-debian/tmp-cunit-ncurses/usr/include usr
-debian/tmp-cunit-ncurses/usr/lib/lib*.a usr/lib
-debian/tmp-cunit-ncurses/usr/lib/lib*.so usr/lib
-debian/tmp-cunit-ncurses/usr/share/man/man3 usr/share/man
-debian/cunit.pc usr/lib/pkgconfig
+debian/tmp-cunit-ncurses/usr/include usr
+debian/tmp-cunit-ncurses/usr/lib/lib*.a usr/lib
+debian/tmp-cunit-ncurses/usr/lib/lib*.so usr/lib
+debian/tmp-cunit-ncurses/usr/share/man/man3 usr/share/man
+debian/tmp-cunit-ncurses/usr/lib/pkgconfig/cunit.pc usr/lib/pkgconfig
Reply to: