[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#502559: marked as done (Include from libqt3-headers Fails With -Werror.)

Your message dated Wed, 20 Jun 2012 11:03:14 +0000
with message-id <[🔎] E1ShIgs-00078Z-Vq@franck.debian.org>
and subject line Bug#678210: Removed package(s) from unstable
has caused the Debian Bug report #502559,
regarding Include from libqt3-headers Fails With -Werror.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

502559: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502559
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: libqt3-headers
Version: 3:3.3.8b-5

Software that tries to build against Qt3's qimage.h with the -Werror
compiler flag will fail in Lenny. Apparently g++ has gotten more picky
about order of operations:

/usr/include/qt3/qimage.h: In member function 'bool
QImageTextKeyLang::operator<(const QImageTextKeyLang&) const':
/usr/include/qt3/qimage.h:61: error: suggest parentheses around &&
within ||

This can be worked around by using the -Wno-parentheses CPPFLAG, but it
would be far better if it were actually fixed in the header.

As such, I've written and tested the attached patch.

Author: Pat Suwalski <pats@xandros.com>

This patch fixes the QImage header breaking with -Werror on Lenny:

/usr/include/qt3/qimage.h: In member function
  'bool QImageTextKeyLang::operator<(const QImageTextKeyLang&) const':
/usr/include/qt3/qimage.h:61: error: suggest parentheses around && within ||

--- a/src/kernel/qimage.h	2008-10-17 19:28:30.000000000 +0000
+++ b/src/kernel/qimage.h	2008-10-17 19:29:00.000000000 +0000
@@ -58,7 +58,7 @@
     QCString lang;
     bool operator< (const QImageTextKeyLang& other) const
-	{ return key < other.key || key==other.key && lang < other.lang; }
+	{ return key < other.key || (key==other.key && lang < other.lang); }
     bool operator== (const QImageTextKeyLang& other) const
 	{ return key==other.key && lang==other.lang; }

--- End Message ---
--- Begin Message ---
Version: 3:3.3.8b-11+rm

Dear submitter,

as the package qt-x11-free has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/678210

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing

Debian distribution maintenance software
Alexander Reichle-Schmehl (the ftpmaster behind the curtain)

--- End Message ---

Reply to: