[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#589328: marked as done (Short write in nstx_tuntap.c)

Your message dated 
with message-id <20100909203528.4772.62981.mass-bugs-close@merkel.debian.org>
and subject line nstx removed from Debian unstable
has caused the Debian Bug report #589328,
regarding Short write in nstx_tuntap.c
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

589328: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589328
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: nstx 
Version: 1.1-beta6-6
Severity: normal
Tags: patch
Justification: Policy 9.3.2
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch


In ubuntu we applied the attached patch and we think you're interested
to apply it too. The purpose of this patch is to fix ignoring the return
value of a possible short write in nstx_tuntap.c. Thanks. 

## fix-return-values.dpatch by  <sistpoty@ubuntu.com>
## All lines beginning with `## DP:' are a description of the patch.
## DP: No description.

--- nstx-1.1-beta6~/nstx_tuntap.c	2009-10-10 13:57:50.000000000 +0200
+++ nstx-1.1-beta6/nstx_tuntap.c	2009-10-10 13:58:17.000000000 +0200
@@ -266,7 +266,21 @@
 sendtun(const char *data, size_t len)
 //   printf("Sent len %d, csum %d\n", len, checksum(data, len));
-   write(tfd, data, len);
+	size_t count;
+	ssize_t ret;
+	for (count = 0; count < len; count += ret) {
+		ret = write(tfd, data + count, len - count);
+		if (ret < 0) {
+			if (errno == EINTR) {
+				ret = 0;
+				continue;
+			}
+			return;
+		}
+	}

--- End Message ---
--- Begin Message ---
Version: 1.1-beta6-6+rm

nstx has been removed from Debian unstable: http://bugs.debian.org/595988

Closing its bugs with a Version higher than the last unstable upload.

More information about this script at:

--- End Message ---

Reply to: