[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#559814: ITA: hamlib / new version for upload

On Tue, Feb 16, 2010 at 07:53:53PM -0800, Kamal Mostafa wrote:
> I wasn't sure what to do with the debian/control "Uploaders:" field.  As
> a placeholder, I set it to the debian-hams@lists.debian.org list address
> -- I expect that it will be changed by the actual uploader:
>   Uploaders: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
> This is my first experience with maintenance of a package at Debian, so
> I am not at all sure that I'm following the proper procedures here.  Any
> guidance will be much appreciated.

So, I've just checked your package and it looks generally OK to me. I'll
proceed to upload it to DELAYED/1, just to give other people a bit of
time to react in case there are reservations.

The few comments I've are as follows, please consider them in future

- I've switched your Maintainer/Uploaders line, to match the best
  practices on that. Maintainer is the official contact address (the
  mailing list) and Uploaders is the list of people usually *working*
  (not just doing the final upload, despite the name) on the package,
  hence you in this case. Please port the change to your working copy of
  the packaging.

- You install a couple more .so files than in the past, however these
  new .so are not versioned, I believe it is an upstream choice, but you
  should discuss with them whether this is really intended or not.

- As hamlib has a homepage (the sourceforce page), you should declare it
  in debian/control using the "Homepage" field, check the developer's
  reference for details. If you use some version control system to
  maintain the packaging, you should declare that too using the Vcs-*
  fields (again, devref has details about that).

- There are quite a lot of lintian warnings, you should fix them. Most
  of them are missing ${misc:Depends} substvar that are recommended if
  you use debhelper (as you do) in the packaging; please add them.

Thanks for your work!

Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
zack@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..|  .  |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime

Reply to: