[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#359046: marked as done (mc: FTBFS (ppc64): Please do not use 'umode_t')



Your message dated Wed, 13 Feb 2008 22:17:04 +0000
with message-id <E1JPPua-0004hd-5E@ries.debian.org>
and subject line Bug#359046: fixed in mc 1:4.6.2~pre1-1
has caused the Debian Bug report #359046,
regarding mc: FTBFS (ppc64): Please do not use 'umode_t'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
359046: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=359046
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: mc
Version: 1:4.6.1-2
Severity: wishlist
Tags: patch

Hello,

when building 'mc' on ppc64/unstable, I get the following error:

In file included from /usr/include/asm/types.h:8,
                 from /usr/include/asm-ppc64/elf.h:4,
                 from /usr/include/asm/elf.h:8,
                 from /usr/include/asm-ppc64/sigcontext.h:12,
                 from /usr/include/asm/sigcontext.h:8,
                 from /usr/include/bits/sigcontext.h:28,
                 from /usr/include/signal.h:333,
                 from tcputil.c:22:
/usr/include/asm-ppc64/types.h:19: error: two or more data types in declaration specifiers
make[5]: *** [tcputil.o] Error 1
make[5]: Leaving directory `/mc-4.6.1/vfs'

With the attached patch 'mc' can be compiled on ppc64.

The patch replaces the occurrences of the linux kernel specific type
'umode_t' by 'mode_t' and drops the problematic 'AC_CHECK_TYPE(umode_t, int)' 
type check/definition from configure.ac and configure.

Regards
Andreas Jochens

diff -urN ../tmp-orig/mc-4.6.1/src/achown.c ./src/achown.c
--- ../tmp-orig/mc-4.6.1/src/achown.c	2005-07-23 16:52:02.000000000 +0000
+++ ./src/achown.c	2006-03-25 18:52:50.000000000 +0000
@@ -84,7 +84,7 @@
 static int x_toggle;
 static char ch_flags[11];
 static const char ch_perm[] = "rwx";
-static umode_t ch_cmode;
+static mode_t ch_cmode;
 static struct stat *sf_stat;
 static int need_update;
 static int end_chown;
@@ -143,9 +143,9 @@
     }
 }
 
-static umode_t get_perm (char *s, int base)
+static mode_t get_perm (char *s, int base)
 {
-    umode_t m;
+    mode_t m;
 
     m = 0;
     m |= (s [0] == '-') ? 0 :
@@ -160,9 +160,9 @@
     return m;
 }
 
-static umode_t get_mode (void)
+static mode_t get_mode (void)
 {
-    umode_t m;
+    mode_t m;
 
     m = ch_cmode ^ (ch_cmode & 0777);
     m |= get_perm (ch_flags, 6);
diff -urN ../tmp-orig/mc-4.6.1/src/file.c ./src/file.c
--- ../tmp-orig/mc-4.6.1/src/file.c	2005-05-27 14:19:18.000000000 +0000
+++ ./src/file.c	2006-03-25 18:52:50.000000000 +0000
@@ -97,7 +97,7 @@
     dev_t dev;
     ino_t ino;
     short linkcount;
-    umode_t st_mode;
+    mode_t st_mode;
     char name[1];
 };
 
diff -urN ../tmp-orig/mc-4.6.1/configure.ac ./configure.ac
--- ../tmp-orig/mc-4.6.1/configure.ac	2005-07-23 16:52:49.000000000 +0000
+++ ./configure.ac	2006-03-25 18:52:50.000000000 +0000
@@ -210,7 +210,6 @@
 dnl 
 
 AC_TYPE_MODE_T
-AC_CHECK_TYPE(umode_t, int)
 AC_CHECK_TYPE(off_t, long)
 AC_TYPE_PID_T
 AC_TYPE_UID_T
diff -urN ../tmp-orig/mc-4.6.1/configure ./configure
--- ../tmp-orig/mc-4.6.1/configure	2005-07-23 16:53:09.000000000 +0000
+++ ./configure	2006-03-25 18:52:42.000000000 +0000
@@ -13667,72 +13667,6 @@
 
 fi
 
-echo "$as_me:$LINENO: checking for umode_t" >&5
-echo $ECHO_N "checking for umode_t... $ECHO_C" >&6
-if test "${ac_cv_type_umode_t+set}" = set; then
-  echo $ECHO_N "(cached) $ECHO_C" >&6
-else
-  cat >conftest.$ac_ext <<_ACEOF
-/* confdefs.h.  */
-_ACEOF
-cat confdefs.h >>conftest.$ac_ext
-cat >>conftest.$ac_ext <<_ACEOF
-/* end confdefs.h.  */
-$ac_includes_default
-int
-main ()
-{
-if ((umode_t *) 0)
-  return 0;
-if (sizeof (umode_t))
-  return 0;
-  ;
-  return 0;
-}
-_ACEOF
-rm -f conftest.$ac_objext
-if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5
-  (eval $ac_compile) 2>conftest.er1
-  ac_status=$?
-  grep -v '^ *+' conftest.er1 >conftest.err
-  rm -f conftest.er1
-  cat conftest.err >&5
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); } &&
-	 { ac_try='test -z "$ac_c_werror_flag"
-			 || test ! -s conftest.err'
-  { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
-  (eval $ac_try) 2>&5
-  ac_status=$?
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); }; } &&
-	 { ac_try='test -s conftest.$ac_objext'
-  { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
-  (eval $ac_try) 2>&5
-  ac_status=$?
-  echo "$as_me:$LINENO: \$? = $ac_status" >&5
-  (exit $ac_status); }; }; then
-  ac_cv_type_umode_t=yes
-else
-  echo "$as_me: failed program was:" >&5
-sed 's/^/| /' conftest.$ac_ext >&5
-
-ac_cv_type_umode_t=no
-fi
-rm -f conftest.err conftest.$ac_objext conftest.$ac_ext
-fi
-echo "$as_me:$LINENO: result: $ac_cv_type_umode_t" >&5
-echo "${ECHO_T}$ac_cv_type_umode_t" >&6
-if test $ac_cv_type_umode_t = yes; then
-  :
-else
-
-cat >>confdefs.h <<_ACEOF
-#define umode_t int
-_ACEOF
-
-fi
-
 echo "$as_me:$LINENO: checking for off_t" >&5
 echo $ECHO_N "checking for off_t... $ECHO_C" >&6
 if test "${ac_cv_type_off_t+set}" = set; then


--- End Message ---
--- Begin Message ---
Source: mc
Source-Version: 1:4.6.2~pre1-1

We believe that the bug you reported is fixed in the latest version of
mc, which is due to be installed in the Debian FTP archive:

mc_4.6.2~pre1-1.diff.gz
  to pool/main/m/mc/mc_4.6.2~pre1-1.diff.gz
mc_4.6.2~pre1-1.dsc
  to pool/main/m/mc/mc_4.6.2~pre1-1.dsc
mc_4.6.2~pre1-1_i386.deb
  to pool/main/m/mc/mc_4.6.2~pre1-1_i386.deb
mc_4.6.2~pre1.orig.tar.gz
  to pool/main/m/mc/mc_4.6.2~pre1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 359046@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Winnertz <winnie@debian.org> (supplier of updated mc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 13 Feb 2008 23:00:30 +0100
Source: mc
Binary: mc
Architecture: source i386
Version: 1:4.6.2~pre1-1
Distribution: unstable
Urgency: low
Maintainer: Debian MC Packaging Group <pkg-mc-devel@lists.alioth.debian.org>
Changed-By: Patrick Winnertz <winnie@debian.org>
Description: 
 mc         - midnight commander - a powerful file manager
Closes: 109963 109963 118717 192882 198194 227875 248646 258253 273699 291181 301537 301539 301732 302516 304886 305642 309186 324920 329186 346037 349390 359046 367348 397333 407593 420437 428567 428993 455564 458208
Changes: 
 mc (1:4.6.2~pre1-1) unstable; urgency=low
 .
   * New upstream release.
     + (Closes: #301732)
     + (Closes: #192882)
     + (Closes: #248646)
     + (Closes: #258253)
     + (Closes: #273699)
     + (Closes: #302516)
     + (Closes: #305642)
     + (Closes: #309186)
     + (Closes: #458208)
     + (Closes: #420437)
     + (Closes: #346037)
     + (Closes: #367348)
     + (Closes: #118717)
     + (Closes: #349390)
     + (Closes: #304886)
     + (Closes: #329186)
     + (Closes: #324920)
     + (Closes: #109963)
     + (Closes: #227875)
     + (Closes: #397333)
     + (Closes: #428567)
     + (Closes: #428993)
     + (Closes: #301537)
     + (Closes: #301539)
     + (Closes: #359046)
     + (Closes: #407593)
     + (Closes: #198194)
     + (Closes: #109963)
   * New maintainer: pkg-mc-devel@lists.alioth.debian.org (Closes: #455564)
   * New Uploader: myself
   * Bumped Standards-Version to 3.7.3
     + Menu Transition: Apps/Tools --> Applications/File Management
   * Added Homepage header to control file
   * Rediffed all patches for 4.6.2~pre1
   * Add patch to ignore chmod errors in ftpfs, since if you copy many files to
     a ftp server, without SITE CHMOD support, you'll get everytime a warning.
     (Closes: #291181)
   * Bump debian/compat to 5 (and switch from export DH_COMPAT to this file)
   * Removes Conflicts/Replaces in debian/control, since these packages doesn't
     exist any longer in the debian pool.
   * Removed some empty dirs (usr/sbin)
   * Build de.po/it.po & ru.po new in build target
Files: 
 42f4b51d8904d0600a010f8304416b1a 742 utils optional mc_4.6.2~pre1-1.dsc
 a8111650a0cdb110af3de1acfcf04b82 4039774 utils optional mc_4.6.2~pre1.orig.tar.gz
 bab36988a2bee8916d2a3f471c53af87 84527 utils optional mc_4.6.2~pre1-1.diff.gz
 0bd8c079ef960688732b00605bff68e5 2183308 utils optional mc_4.6.2~pre1-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHs2oxzgm26bkTFDoRAky/AJ9jNtR2OUKpO6ZYNp+HIsyHaWQaKACfVivu
jpRHzm9dO/e4xdcpVwy8MKw=
=gQdo
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: