Bug#186876: marked as done (xmms: [patch] allow remote setting of no playlist advance )
Your message dated Sun, 18 Sep 2005 00:16:45 -0500
with message-id <1127020605.4857.18.camel@cerdita>
and subject line Closing
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 30 Mar 2003 19:27:29 +0000
>From asf@void.at Sun Mar 30 13:27:26 2003
Return-path: <asf@void.at>
Received: from ycpmailsrv01.ycn.com [212.88.160.6]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18ziSk-0007pT-00; Sun, 30 Mar 2003 13:27:26 -0600
Received: from eris.void.at (212-88-187-152.ADSL.ycn.com [212.88.187.152])
by ycpmailsrv01.ycn.com (8.12.3/8.12.3/Debian -4) with ESMTP id h2UJIL0p020779
for <submit@bugs.debian.org>; Sun, 30 Mar 2003 21:18:21 +0200
Received: from asf by eris.void.at with local (Exim 3.36 #1 (Debian))
id 18ziSE-0007uO-00
for <submit@bugs.debian.org>; Sun, 30 Mar 2003 21:26:54 +0200
From: "Andreas Fuchs <Andreas Fuchs" <asf@acm.org>
Mail-Copies-To: Debian Bug Tracking System <submit@bugs.debian.org> never
X-Url: http://asf.void.at/
To: submit@bugs.debian.org
Subject: xmms: [patch] allow remote setting of no playlist advance
X-Debbugs-CC: Andreas Fuchs <Andreas Fuchs <asf@acm.org>>
X-Attribution: asf
X-Face: 3*3w/y?I6|`'CYW7F~m0]U1)L\|[x"?/V6^;s3FU#q|F'AL(3C?$eslHvAmR:KjT"&LZeqM
0wMS%HM`
From: Andreas Fuchs <asf@void.at>
Message-ID: <87adfcveo1.fsf@eris.void.at>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Sun, 30 Mar 2003 21:26:54 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-5.2 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SIGNATURE_SHORT_SPARSE,
SPAM_PHRASE_00_01,X_DEBBUGS_CC
version=2.44
X-Spam-Level:
--=-=-=
Package: xmms
Version: 1.2.7-2
Severity: wishlist
Tags: patch, upstream
Hi,
I have hacked up a patch to export "no playlist advance" setter/getter
functions in xmmsctrl.h, which I would like to access from xmms-shell
(I'll mail a patch to its archive as soon as I have one (-:).
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=xmms-noadvance.diff
diff -urN xmms-1.2.7/libxmms/xmmsctrl.c xmms-mine/libxmms/xmmsctrl.c
--- xmms-1.2.7/libxmms/xmmsctrl.c 2002-03-03 21:24:27.000000000 +0100
+++ xmms-mine/libxmms/xmmsctrl.c 2003-03-30 20:36:04.000000000 +0200
@@ -385,7 +385,7 @@
if ((fd = xmms_connect_to_session(session)) == -1)
return;
- remote_send_packet(fd, CMD_GET_VOLUME, NULL, 0);
+ remote_send_packet(fd,CMD_GET_VOLUME, NULL, 0);
data = remote_read_packet(fd, &pkt_hdr);
if (data)
{
@@ -754,6 +754,24 @@
close(fd);
}
+void xmms_remote_set_no_playlist_advance (gint session, gint value)
+{
+ gint fd;
+ gchar data[sizeof(gint)];
+
+ if ((fd = xmms_connect_to_session(session)) == -1)
+ return;
+ *((gint *) data) = value;
+ remote_send_packet(fd, CMD_SET_NO_PLAYLIST_ADVANCE, data, sizeof(data));
+ remote_read_ack(fd);
+ close(fd);
+}
+
+gboolean xmms_remote_is_no_playlist_advance (gint session)
+{
+ return remote_get_gboolean(session, CMD_IS_NO_PLAYLIST_ADVANCE);
+}
+
void xmms_remote_quit(gint session)
{
gint fd;
diff -urN xmms-1.2.7/libxmms/xmmsctrl.h xmms-mine/libxmms/xmmsctrl.h
--- xmms-1.2.7/libxmms/xmmsctrl.h 2002-03-03 21:24:27.000000000 +0100
+++ xmms-mine/libxmms/xmmsctrl.h 2003-03-30 20:35:09.000000000 +0200
@@ -82,6 +82,10 @@
/* Added in XMMS 1.2.6 */
void xmms_remote_play_pause(gint session);
void xmms_remote_playlist_ins_url_string(gint session, gchar * string, gint pos);
+/* Added by Andreas Fuchs */
+void xmms_remote_set_no_playlist_advance (gint session, gint value);
+gboolean xmms_remote_is_no_playlist_advance (gint session);
+
#ifdef __cplusplus
};
diff -urN xmms-1.2.7/po/xmms.pot xmms-mine/po/xmms.pot
diff -urN xmms-1.2.7/xmms/controlsocket.c xmms-mine/xmms/controlsocket.c
--- xmms-1.2.7/xmms/controlsocket.c 2002-03-03 21:24:33.000000000 +0100
+++ xmms-mine/xmms/controlsocket.c 2003-03-30 21:05:20.000000000 +0200
@@ -390,6 +390,22 @@
ctrl_write_gfloat(pkt->fd, equalizerwin_get_band(i));
ctrl_ack_packet(pkt);
break;
+ case CMD_SET_NO_PLAYLIST_ADVANCE:
+ if (pkt->data)
+ {
+ cfg.no_playlist_advance = *(gint*) pkt->data;
+ } else {
+ cfg.no_playlist_advance = !cfg.no_playlist_advance;
+ }
+ GTK_CHECK_MENU_ITEM(gtk_item_factory_get_widget(mainwin_options_menu, "/No Playlist Advance"))->active =
+ cfg.no_playlist_advance;
+ ctrl_ack_packet (pkt);
+ break;
+ case CMD_IS_NO_PLAYLIST_ADVANCE:
+ ctrl_write_gboolean(pkt->fd, cfg.no_playlist_advance);
+ ctrl_ack_packet (pkt);
+ break;
+
default:
pthread_mutex_lock(&packet_list_mutex);
packet_list = g_list_append(packet_list, pkt);
diff -urN xmms-1.2.7/xmms/controlsocket.h xmms-mine/xmms/controlsocket.h
--- xmms-1.2.7/xmms/controlsocket.h 2002-03-03 21:24:33.000000000 +0100
+++ xmms-mine/xmms/controlsocket.h 2003-03-30 20:24:23.000000000 +0200
@@ -46,6 +46,7 @@
CMD_GET_EQ, CMD_GET_EQ_PREAMP, CMD_GET_EQ_BAND,
CMD_SET_EQ, CMD_SET_EQ_PREAMP, CMD_SET_EQ_BAND,
CMD_QUIT, CMD_PLAYLIST_INS_URL_STRING, CMD_PLAYLIST_INS, CMD_PLAY_PAUSE,
+ CMD_SET_NO_PLAYLIST_ADVANCE, CMD_IS_NO_PLAYLIST_ADVANCE,
};
typedef struct
--=-=-=
Have fun,
Andreas.
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux eris.void.at 2.4.20-xfs #6 SMP Sun Feb 9 17:54:48 CET 2003 i686 unknown unknown GNU/Linux
Versions of the packages xmms depends on:
ii libc6 2.3.1-14 GNU C Library: Shared libraries and Timezone
ii libglib1.2 1.2.10-6 The GLib library of C routines
ii libgtk1.2 1.2.10-14 The GIMP Toolkit set of widgets for X
ii xlibs 4.2.1-6 X Window System client libraries
--
Andreas Fuchs, <asf@acm.org>, asf@jabber.at, antifuchs
--=-=-=--
---------------------------------------
Received: (at 186876-done) by bugs.debian.org; 18 Sep 2005 05:17:23 +0000
>From damog@debian.org Sat Sep 17 22:17:22 2005
Return-path: <damog@debian.org>
Received: from ns3.jiffynet-hosting.net (server146.jiffynet-hosting.net) [69.57.162.87]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EGrYI-0008Hm-00; Sat, 17 Sep 2005 22:17:22 -0700
Received: from dsl-201-129-37-187.prod-infinitum.com.mx ([201.129.37.187] helo=[192.168.1.48])
by server146.jiffynet-hosting.net with asmtp (Exim 4.34)
id 1EGrY0-0003tZ-Pm
for 186876-done@bugs.debian.org; Sun, 18 Sep 2005 01:17:11 -0400
Subject: Closing
From: David Moreno Garza <damog@debian.org>
To: 186876-done@bugs.debian.org
Content-Type: text/plain; charset=ISO-8859-1
Date: Sun, 18 Sep 2005 00:16:45 -0500
Message-Id: <1127020605.4857.18.camel@cerdita>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.3
Content-Transfer-Encoding: quoted-printable
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server146.jiffynet-hosting.net
X-AntiAbuse: Original Domain - bugs.debian.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - debian.org
X-Source:
X-Source-Args:
X-Source-Dir:
Delivered-To: 186876-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-2.0 required=4.0 tests=BAYES_00,ONEWORD autolearn=no
version=2.60-bugs.debian.org_2005_01_02
I'm closing this bug since:
- The patch attached is no longer applicable.
- Last activity on the bug was in 2003.
Cheers,
--
David Moreno Garza <damog@damog.net> | http://www.damog.net/
<damog@debian.org> | GPG: C671257D
Veneno quisiera haber sido, para as=ED en tu pecho clavarte un pu=F1al.
Reply to: