[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#232657: marked as done (apt-src: APT::Src::BuildCommand in example config is misleading)

Your message dated Mon, 28 Jun 2004 16:32:02 -0400
with message-id <E1Bf2nK-00030R-00@newraff.debian.org>
and subject line Bug#232657: fixed in apt-src 0.25.1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 14 Feb 2004 15:19:13 +0000
>From mbanck@gmx.net Sat Feb 14 07:19:13 2004
Return-path: <mbanck@gmx.net>
Received: from mail.gmx.de (mail.gmx.net) [] 
	by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
	id 1As1ZY-0006G3-00; Sat, 14 Feb 2004 07:19:13 -0800
Received: (qmail 24629 invoked by uid 65534); 14 Feb 2004 15:18:41 -0000
Received: from dj.stud.chemie.tu-muenchen.de (EHLO blackbird.oase.mhn.de) (
  by mail.gmx.net (mp010) with SMTP; 14 Feb 2004 16:18:41 +0100
X-Authenticated: #686195
Received: from mbanck by blackbird.oase.mhn.de with local (Exim 3.36 #1 (Debian))
	id 1As1Ym-0004XC-00
	for <submit@bugs.debian.org>; Sat, 14 Feb 2004 16:18:24 +0100
Date: Sat, 14 Feb 2004 16:18:23 +0100
From: Michael Banck <mbanck@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: apt-src: APT::Src::BuildCommand in example config is misleading
Message-ID: <20040214151822.GA15228@blackbird.oase.mhn.de>
Reply-To: Michael Banck <mbanck@debian.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
X-Reportbug-Version: 2.28
User-Agent: Mutt/1.5.4i
Sender: Michael Banck <mbanck@gmx.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_12 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: apt-src
Version: 0.24
Severity: normal
Tags: patch

/usr/share/doc/apt-src/examples/config says:

/* A command to use to build a tree. -rfakeroot is appended for non-root
 * users. */
//APT::Src::BuildCommand "dpkg-buildpackage -b -us -uc";

However, without adding -rfakeroot manually to APT::Src::BuildCommand in
~/.apt-src/config, building fail when e.g. dh_testroot is called.

Hmm, looking at AptSrc.pm, it seems -rfakeroot does not get added when
APT::Src::BuildCommand is set, which looks like an oversight.

Patch attached.


-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux blackbird.oase.mhn.de 2.4.21-2-386 #1 Fri Jul 4 22:32:38 EST 2003 i686

Versions of packages apt-src depends on:
ii  apt                           0.5.12     Advanced front-end for dpkg
ii  dpkg-dev                      1.10.18    Package building tools for Debian
ii  libapt-pkg-perl               0.1.10     Perl interface to libapt-pkg
ii  perl                          5.8.2-2    Larry Wall's Practical Extraction 

Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=diff

--- AptSrc.pm.orig	2004-02-14 16:10:16.000000000 +0100
+++ AptSrc.pm	2004-02-14 16:10:53.000000000 +0100
@@ -531,6 +531,9 @@
 	else {
 		@command=split(/\s+/, $_config->get('APT::Src::BuildCommand'));
+		if ($> != 0) {
+			push @command, "-rfakeroot";
+		}
 	if ($this->do(@command) != 0) {
 		$this->error("Building failed");


Received: (at 232657-close) by bugs.debian.org; 28 Jun 2004 20:38:12 +0000
>From katie@ftp-master.debian.org Mon Jun 28 13:38:12 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bf2tI-0000tJ-00; Mon, 28 Jun 2004 13:38:12 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1Bf2nK-00030R-00; Mon, 28 Jun 2004 16:32:02 -0400
From: Laszlo Boszormenyi (GCS) <gcs@lsc.hu>
To: 232657-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#232657: fixed in apt-src 0.25.1
Message-Id: <E1Bf2nK-00030R-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 28 Jun 2004 16:32:02 -0400
Delivered-To: 232657-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-CrossAssassin-Score: 3

Source: apt-src
Source-Version: 0.25.1

We believe that the bug you reported is fixed in the latest version of
apt-src, which is due to be installed in the Debian FTP archive:

  to pool/main/a/apt-src/apt-src_0.25.1.dsc
  to pool/main/a/apt-src/apt-src_0.25.1.tar.gz
  to pool/main/a/apt-src/apt-src_0.25.1_all.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 232657@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Laszlo Boszormenyi (GCS) <gcs@lsc.hu> (supplier of updated apt-src package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Sat, 22 May 2004 13:12:36 +0000
Source: apt-src
Binary: apt-src
Architecture: source all
Version: 0.25.1
Distribution: unstable
Urgency: low
Maintainer: Laszlo Boszormenyi (GCS) <gcs@lsc.hu>
Changed-By: Laszlo Boszormenyi (GCS) <gcs@lsc.hu>
 apt-src    - manage Debian source packages
Closes: 183223 186171 232657 240396
 apt-src (0.25.1) unstable; urgency=low
   * Bugfix release:
     - Install latest version of package sources (thanks to Eric Wong
       <eric@petta-tech.com>, closes: #183223).
     - Add -rfakeroot to APT::Src::BuildCommand for non root users (thanks to
       Michael Banck <mbanck@debian.org>, closes: #232657).
     - Add configuration item APT::Src::NoDeleteSource for not removing source
       files with source package (thanks to David B Harris
       <david@eelf.ddts.net>, closes: #186171).
   * New maintainer (closes: #240396).
 31c952fb9eb0ad1a32aa09c8ddabfb54 515 admin optional apt-src_0.25.1.dsc
 180f2a5f1f97b34e2a0a952ebea87f78 19236 admin optional apt-src_0.25.1.tar.gz
 8d3cceb7d579fa550e95830d7fa6a778 29500 admin optional apt-src_0.25.1_all.deb

Version: GnuPG v1.2.4 (GNU/Linux)


Reply to: