On Tue, Dec 08, 2020 at 09:33:03PM +0100, Peter Wienemann wrote: > Dear Python experts, > > in trying to update the python-lark package [0] to the most recent upstream > version, an interesting issue regarding unit tests showed up [1]. Depending > on how one runs unit tests they either fail or not. Tried options are: > > 1. PYTHONWARNINGS=d pythonX -m unittest discover -v tests > 2. pythonX setup.py test > 3. pythonX -m tests Option 3 runs https://github.com/lark-parser/lark/blob/master/tests/__main__.py which mostly just runs unittest.main(). Option 2 seems to run the same file according to setup.py. I'm not familiar with unittests enough know the difference between options 1 and 3. You didn't explain what actual problems do you have, but https://github.com/lark-parser/lark/issues/792 suggests that some way you used was skipping some of the tests? > Upstream uses option 3 in its CI testing [2] and did not see any issues with > lark release 0.11.1. dh_auto_test seems to use option 2 by default (for the > pybuild build system). For autopkgtest I have chosen to use option 1. The > latter two options both fail for version 0.11.1. Which is good? > After applying a patch provided by upstream [3], also option 2 works but option 1 still fails. Which is good or bad? I'm not sure. > Upstream suggested to change the way the (autopkgtest) tests are run [4]. So are you asking only about autopkgtests, not build-time tests? > Is there something like a general recommendation on what is the best way > to run Python unit tests? No (except "whatever the upstream CI runs"). -- WBR, wRAR
Attachment:
signature.asc
Description: PGP signature