Re: RFS: python-unicodecsv (Closes: #669678)
- To: debian-python@lists.debian.org
- Subject: Re: RFS: python-unicodecsv (Closes: #669678)
- From: Thomas Bechtold <thomasbechtold@jpberlin.de>
- Date: Fri, 04 May 2012 22:48:37 +0200
- Message-id: <[🔎] 1336164517.11133.2.camel@salbei.fritz.box>
- In-reply-to: <20120426223937.GA3662@jwilk.net>
- References: <1335097011.2567.24.camel@salbei.fritz.box> <20120423144944.GA2212@jwilk.net> <1335195277.31036.12.camel@salbei.fritz.box> <20120423155240.GA4413@jwilk.net> <1335198730.31036.17.camel@salbei.fritz.box> <20120423180336.GA8061@jwilk.net> <1335415687.2744.5.camel@salbei.fritz.box> <20120426223937.GA3662@jwilk.net>
On Fri, 2012-04-27 at 00:39 +0200, Jakub Wilk wrote:
> * Thomas Bechtold <thomasbechtold@jpberlin.de>, 2012-04-26, 06:48:
> >i fixed all the stuff (see comments below) and uploaded a new package
> >to mentors.debian.net . if there are no other issues, i'll add the
> >debian-dir to the python-modules svn
>
> Please feel free to inject the package even though there are some (minor)
> issues. :) We turn a blind eye to non-perfect packages in our svn. ;)
done.
> >thanks. i forwarded the patch upstream and included the patch in
> >debian/patches
>
> I think Forwared should be simply:
>
> Forwarded: https://github.com/jdunck/python-unicodecsv/pull/11
>
> (The DEP-3 specifications reads: “Any value other than "no" or "not-needed"
> means that the patch has been forwarded upstream. Ideally the value is an URL
> proving that it has been forwarded and where one can find more information
> about its inclusion status.”)
>
> >>>>Please test against all supported Python versions, not only the
> >>>>default one.
> >>>at build time? how to do this? what are the build dependencies in
> >>>debian/control
> >>python-all
> >done.
>
> ...But you shouldn't have removed "python (>= 2.6.6-3~)", as this
> version is needed for dh_python2. Alternatively, you could make
> python-all versioned. (This is not very important, as the required
> version is available in stable anyway.)
fixed this already in svn.
> What are "build/*" in debian/clean and "rmdir unicodecsv.egg-info | true"
> in debian/rules for? They look suspicious to me.
when i build the package, the directories "build" and
"unicodecsv.egg-info" are created. i thought i have to remove both
during the clean.
Reply to: