[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: transmissionrpc (fixed)



Hello Timur :)

I reviewed your package a bit, here are my suggestions:

Upstream tarball:
* Ask upstream if they can remove .hg* files.

debian/copyright:
* Provide copyright informations about your Debian packaging.
* Replace (c) with ©, the latter has legal validity.

debian/control:
* Bump Standards-Version to 3.8.3.
* You probably miss a dependency on transmission.
* Remove XB-Python-Version from binary stanza, useless with
  python-support.
* Long description should be improved.

debian/docs:
* Is LICENSE required? I see you added an override for this.

debian/examples:
* helical.py seems a useful script to be installed in /usr/bin, what
  about the others?

debian/README.source:
* You use dpatch, please provide a README.source to document its usage.

debian/rules:
* You could consider to switch to full dh7, so you can reduce it a lot,
  but it's up to you :)

Thank you, and best regards!

-- 
  .''`.
 :  :' :   Luca Falavigna <dktrkranz@debian.org>
 `.  `'
   `-

Attachment: signature.asc
Description: PGP signature


Reply to: