On Sat, 2010-09-18 at 13:56 -0400, Rick Thomas wrote: [...] > >> And this script > >> adds spaces and quotes around key/value pairs and let /dev/disk/by-* > >> names. This is not compatible with yaboot. > > > > Which of those things is not compatible with yaboot? > > > It's not yaboot per-se that is incompatible. The extra quotes and > spaces mess up the "ybin" script which is used in installing yaboot. > My patch fixes that specific problem (and a couple of other specific > problems) in a very non-general way. The value of the kernel (or rather initramfs) root parameter generally does need to include an '=' character and linux-base.postinst is correct to use it. It must then double-quote the value in yaboot.conf so that it is handled correctly by the main configuration parser in cfg.c. Therefore, ybin also needs to accept this format. I could change linux-base.postinst to avoid adding space between name, '=' and value when updating the configuration but it seems simple enough to make ybin accept that too. > I'd recommend a complete rewrite > of ybin (at least) if you want to make it work for general lilo-like > syntax. [...] Yes, all parts of yaboot should really be using the same configuration parser. Reimplementing it is crazy. By the way, I think this bug should be merged with #580455. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part