Re: 2.4.21-ben2 compile error

[Michel Dänzer <daenzer@debian.org>]

On Sun, 2003-07-06 at 17:25, Jean-Paul Vincent wrote: 
> Hi,
> 
> Compiling the 2.4.21-ben2 kernel I got :
> 
> --
> make[1]: Leaving directory `/usr/src/benh-2.4.21/arch/ppc/xmon'
> ld -T arch/ppc/vmlinux.lds -Ttext 0xc0000000 -Bstatic 
> arch/ppc/kernel/head.o arch/ppc/kernel/idle_6xx.o init/main.o 
> init/version.o init/do_mounts.o \
>         --start-group \
>         arch/ppc/kernel/kernel.o arch/ppc/platforms/platform.o 
> arch/ppc/mm/mm.o arch/ppc/lib/lib.o kernel/kernel.o mm/mm.o fs/fs.o 
> ipc/ipc.o arch/ppc/xmon/x.o \
>          drivers/char/char.o drivers/block/block.o drivers/misc/misc.o 
> drivers/net/net.o drivers/char/drm/drm.o drivers/ide/idedriver.o 
> drivers/cdrom/driver.o drivers/pci/driver.o 
> drivers/net/wireless/wireless_net.o drivers/macintosh/macintosh.o 
> drivers/video/video.o drivers/usb/usbdrv.o drivers/media/media.o 
> drivers/input/inputdrv.o \
>         net/network.o \
>         /usr/src/benh-2.4.21/lib/lib.a \
>         --end-group \
>         -o vmlinux
> arch/ppc/xmon/x.o(.text+0x24c): In function `xmon_map_scc':
> : référence indéfinie vers « __sysrq_put_key_op »
> make: *** [vmlinux] Erreur 1

I'm using the attached patch to fix this.


-- 
Earthling Michel Dänzer   \  Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast  \     http://svcs.affero.net/rm.php?r=daenzer

--- linux-2.4.21-ben1/arch/ppc/xmon/start.c	2003-04-22 17:44:52.000000000 +0200
+++ linux-2.4.21-ben1-ck3-aa/arch/ppc/xmon/start.c	2003-06-25 14:55:54.000000000 +0200
@@ -236,7 +236,9 @@ xmon_map_scc(void)
 	DLAB = 0x80;
 #endif /* platform */
 
+#ifdef CONFIG_MAGIC_SYSRQ
 	__sysrq_put_key_op('x', &sysrq_xmon_op);
+#endif
 }
 
 static int scc_initialized = 0;