Re: Request for review etc of libmodule-install-substitute-perl
Le 27/11/2020 à 14:01, Xavier a écrit :
> Le 27/11/2020 à 13:22, Andrew Ruthven a écrit :
>> Hi Xavier,
>> First off, thank for taking a look!
>> On Fri, 2020-11-27 at 12:12 +0100, Xavier wrote:
>>> your package is not ready:
>>> Can't locate inc/Module/Installinc/Module/Install.pm in @INC (you
>>> need to install
>>> the inc::Module::Install module) (@INC contains: ...) at
>>> you should patch it to require Module::Install, not
>>> in Makefile.PL:
>>> $ git grep inc::Module::Install
>>> Makefile.PL:use inc::Module::Install;
>> I'm not convinced, when I did that just now I get:
>> Please invoke Module::Install with:
>> use inc::Module::Install;
>> use Module::Install;
>> None of the other libmodule-install-*-perl packages I sampled do that,
>> however they do have a build-depends on libmodule-install-perl, so I
>> have added that.
>> Ahh, and it turned out I was missing some dependencies. Fixed now.
>>> I pushed also some minor changes and enabled continuous integration,
>>> then you'll receive mails for each wrong commit ;-)
>> Thank you.
>> I guess this means I'll get an email if my push just now didn't work.
>> ;) And I did, but I was also watching the pipeline. Very handy!
> OK, it builds fine now. Please:
> * mention inc/Module/* in debian/copyright (see
> * add missing debian/upstream/metadata
> * fix spelling errors in POD docs (in a debian/patches/ file) and
> send patch to upstream:
> + substituations => substitutions
> + writen => written
> (reported by lintian --info)
> * build & autopkgtest OK
> * cme & duck OK
> * copyright OK after ^, but I don't find from where come "years"
Also : "X: perl-module-name-not-mentioned-in-description