[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: "Minor" changes to libconfig-inifiles-perl package (and including new upstream version)



-=| Jonas Smedegaard, Sun, May 31, 2009 at 01:02:21AM +0200 |=-
> On Sat, May 30, 2009 at 11:42:40PM +0200, Salvatore Bonaccorso wrote:
> >> >> >N: Processing binary package libconfig-inifiles-perl (version 2.49-1) ...
> 
> >I shortly investigated the problem and on line 2464 I think there is a 
> >=cut part which shouldn't be, as it does not seem correct. =cut should 
> >"close" a pod block, but there wasn't a real such block on the last 
> >part of lib/Config/IniFiles.pm!
> >
> >In source this should happen: 
> >Index: lib/Config/IniFiles.pm
> >===================================================================
> >--- lib/Config/IniFiles.pm	(revision 36865)
> >+++ lib/Config/IniFiles.pm	(working copy)
> >@@ -2461,10 +2461,6 @@
> > 
> > 1;
> > 
> >-=cut
> >-
> >-1;
> >-
> > # Please keep the following within the last four lines of the file
> > #[JW for editor]:mode=perl:tabSize=8:indentSize=2:noTabs=true:indentOnEnter=true:
> >

That patch looks OK.

> Here's how to apply that patch the CDBS way - in case you want to know:
> 
>   1) copy debian/patches/README from libhtml-wikiconverter-markdown-perl
> 
>   2) add patch as e.g. 1001_fix_pod.patch
> 
>   3) generate series:
> 
>      cd debian/patches; ls -1 0* 1* 2* > series

For points 2)-3) you may want to use quilt natively. A brief crash 
course with quilt is available at 
http://pkg-perl.alioth.debian.org/howto/quilt.html

(though alioth is down at the time I write this)

One more step is to forward the patch upstream so that the problem 
gets fixed for everyone, not jsut Debian users.

-- 
dam

Attachment: signature.asc
Description: Digital signature


Reply to: