[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1121498: marked as done (libreoffice: Preprocessor macros in pdfium confuse arm64 with sparc64)

Your message dated Thu, 18 Dec 2025 15:36:09 +0000
with message-id <E1vWG2z-00D0YX-2U@fasolo.debian.org>
and subject line Bug#1121498: fixed in libreoffice 4:25.8.4-1
has caused the Debian Bug report #1121498,
regarding libreoffice: Preprocessor macros in pdfium confuse arm64 with sparc64
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1121498: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121498
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libreoffice
Version: 4:25.8.3-1
Severity: important
Tags: patch upstream
User: debian-sparc@lists.debian.org
Usertags: sparc64
X-Debbugs-Cc: debian-sparc@lists.debian.org

Hi,

the libreoffice package fails to build from source on sparc64 with:

/tmp/ccLEFgM7.s: Assembler messages:
/tmp/ccLEFgM7.s:10332: Error: Unknown opcode: `qsub'
/tmp/ccLEFgM7.s:10365: Error: Unknown opcode: `qsub'

Further investigation showed that qsub is a valid arm64 instruction, but not
a valid sparc64 instruction. It turned out that the preprocessor check macros
in core/fxcrt/numerics/safe_math_clang_gcc_impl.h contain a typo which causes
arm64 code to be used on sparc64:

#if defined(__ARMEL__) || defined(__arch64__)
#include "core/fxcrt/numerics/safe_math_arm_impl.h"  // IWYU pragma: export
#define BASE_HAS_ASSEMBLER_SAFE_MATH (1)
#else
#define BASE_HAS_ASSEMBLER_SAFE_MATH (0)
#endif

The test for __arch64__ is wrong as the proper test should be for __aarch64__
which is defined on arm64:

(sid_arm64-dchroot)glaubitz@amdahl:~$ echo | gcc -E -dM -|grep arch
#define __aarch64__ 1
(sid_arm64-dchroot)glaubitz@amdahl:~$

On sparc64, __arch64__ is defined:

(sid_sparc64-dchroot)glaubitz@stadler:~$ echo | gcc -E -dM -|grep arch
#define __arch64__ 1
(sid_sparc64-dchroot)glaubitz@stadler:~$

On SPARC, 32-bit and 64-bit systems are differentiated from eacher by testing
whether both __sparc__ and __arch64__ are defined or just __sparc__.

I have reported the issue upstream [1] and provided them with the attached patch.

Thanks,
Adrian

> [1] https://issues.chromium.org/issues/464091911

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

>From 1c815bec0324037494840d01fc579f2a3420e624 Mon Sep 17 00:00:00 2001
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Thu, 27 Nov 2025 13:22:22 +0100
Subject: [PATCH] core/fxcrt/numerics: Fix incorrect preprocessor check on
 aarch64

The preprocessor macro to toggle the use of safe_math_arm_impl.h
currently checks whether __ARMEL__ or __arch64__ are defined. However,
on aarch64, the actual define is called __aarch64__ not __arch64__:

(sid_arm64-dchroot)glaubitz@amdahl:~$ uname -a
Linux amdahl 6.12.57+deb13-arm64 #1 SMP Debian 6.12.57-1 (2025-11-05) aarch64 GNU/Linux
(sid_arm64-dchroot)glaubitz@amdahl:~$ echo | gcc -E -dM -|grep arch
(sid_arm64-dchroot)glaubitz@amdahl:~$

However, the define __arch64__ is used on sparc64:

(sid_sparc64-dchroot)glaubitz@stadler:~$ uname -a
Linux stadler 6.17.0-rc5+ #1 SMP Fri Sep 12 20:37:32 UTC 2025 sparc64 GNU/Linux
(sid_sparc64-dchroot)glaubitz@stadler:~$ echo | gcc -E -dM -|grep arch
(sid_sparc64-dchroot)glaubitz@stadler:~$

This triggers the use of safe_math_arm_impl.h on sparc64 which causes
the compiler to emit the "qsub" instruction which is not recongized:

/tmp/ccLEFgM7.s: Assembler messages:
/tmp/ccLEFgM7.s:10332: Error: Unknown opcode: `qsub'
/tmp/ccLEFgM7.s:10365: Error: Unknown opcode: `qsub'

Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
 core/fxcrt/numerics/safe_math_clang_gcc_impl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/fxcrt/numerics/safe_math_clang_gcc_impl.h b/core/fxcrt/numerics/safe_math_clang_gcc_impl.h
index 58419d5c9..d395ebd3e 100644
--- a/core/fxcrt/numerics/safe_math_clang_gcc_impl.h
+++ b/core/fxcrt/numerics/safe_math_clang_gcc_impl.h
@@ -14,7 +14,7 @@
 
 #include "core/fxcrt/numerics/safe_conversions.h"
 
-#if defined(__ARMEL__) || defined(__arch64__)
+#if defined(__ARMEL__) || defined(__aarch64__)
 #include "core/fxcrt/numerics/safe_math_arm_impl.h"  // IWYU pragma: export
 #define BASE_HAS_ASSEMBLER_SAFE_MATH (1)
 #else
-- 
2.47.3

--- End Message ---
--- Begin Message --- 
Source: libreoffice
Source-Version: 4:25.8.4-1
Done: Rene Engelhard <rene@debian.org>

We believe that the bug you reported is fixed in the latest version of
libreoffice, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1121498@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated libreoffice package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 13 Dec 2025 09:32:27 +0100
Source: libreoffice
Architecture: source
Version: 4:25.8.4-1
Distribution: unstable
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 1121498 1121530 1122336
Changes:
 libreoffice (4:25.8.4-1) unstable; urgency=medium
 .
   * New upstream release
 .
   * debian/patches/pdfium-ports.diff: add patch to fix pdfium build on sparc64
     (closes: #1121498)
   * debian/patches/lpsolve-fPIC.diff: build the shared internal lpsolve with
     -fPIC (as done in system-lpsolve) (closes: #1121530)
   * debian/patches/remove-JITC_PROCESSOR_TYPE-setting.diff: as name says.
     Obsolete and fixes permissions of instdir/program/soffice during build
     (e.g. for smoketest) - closes: #1122336
Checksums-Sha1:
 a0d39fcf0cf56bfa68af02f5a91c26f416a18cc7 37799 libreoffice_25.8.4-1.dsc
 aa698b01c5c22f922f968aefaf2f33b6b3ffcd66 59251276 libreoffice_25.8.4.orig-helpcontent2.tar.xz
 83bcaf3c9550123a97d144ba7d6af080f6404088 233672592 libreoffice_25.8.4.orig-translations.tar.xz
 ae63cd7267b9664157159a5276c2b46614a3bc4d 286883588 libreoffice_25.8.4.orig.tar.xz
 6b9144ea95a0927d7a69ed7d1a5bac7e00d12adf 833 libreoffice_25.8.4.orig.tar.xz.asc
 3c580231185e6f36013440198e6e0adfb46d8c8a 28495456 libreoffice_25.8.4-1.debian.tar.xz
 fe28337d751ec9c663ed50de6b3fc6eb3405a91f 27244 libreoffice_25.8.4-1_source.buildinfo
Checksums-Sha256:
 c049799d508bd31b299cc9311b186cbc1d8c1329e9013e7b9e6a0efb52d4f0ed 37799 libreoffice_25.8.4-1.dsc
 ebc2326ed24033a5b528f4068edbb5fb3afafdef11c042aeb1bcc8434f758f82 59251276 libreoffice_25.8.4.orig-helpcontent2.tar.xz
 fe57f5d526c60b24221eaf984589218795cd2de03516d883303b7bd0bd96ed29 233672592 libreoffice_25.8.4.orig-translations.tar.xz
 1a33dd5888e0b5db648f608e1c6ed7581ec1784f565f38e5c537efa09eacf419 286883588 libreoffice_25.8.4.orig.tar.xz
 97ba5ee9b1977f97f72b36512598ea4d110819c1554d5e8b68097f8c4cbfa0e5 833 libreoffice_25.8.4.orig.tar.xz.asc
 360e922b86f0b173fcb326e0d351cdcce59f652e467b5f37b14458f1a8fb96d3 28495456 libreoffice_25.8.4-1.debian.tar.xz
 0c9a4add98a0b385c1a4a1f0d9ce8c42c96dca32863a8263d4ce5efa50265054 27244 libreoffice_25.8.4-1_source.buildinfo
Files:
 bb3cf46da531d3bc1935c2064b81d688 37799 editors optional libreoffice_25.8.4-1.dsc
 6192dc3ec93b22f42e102834a2fa77c6 59251276 editors optional libreoffice_25.8.4.orig-helpcontent2.tar.xz
 73b565b283e25fdf17ff3662165c85e1 233672592 editors optional libreoffice_25.8.4.orig-translations.tar.xz
 4207b73da25f6c21b941136f75ee1e25 286883588 editors optional libreoffice_25.8.4.orig.tar.xz
 00353d0c76c376a066a8ccec0ee322fc 833 editors optional libreoffice_25.8.4.orig.tar.xz.asc
 4774834abcd4c060d412cda9b5cd7c8e 28495456 editors optional libreoffice_25.8.4-1.debian.tar.xz
 4834baa8346d3df133785e57987b4e31 27244 editors optional libreoffice_25.8.4-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAmk9JXMQHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cOgID/9rNinMLdc1R7cN+YwhSVNFA8HIo9wXp8u/
A1m9ff+mI7H1vwQrZ8eoPfsBYMoHLmDR+nG/RY/tjoePSp5H01ibcwuXpU5w6lxW
XitsCLavRATA5abZqLPC6W/54JE5iWbJHa54CuaG6H6P55EqbwWftfW8ejEU2CP+
2OOl2YtqQirYiVe/gO1Yj3sP0UjHXB+/dqVLU1VRx7YEnG63VXAhpvHSxJcgalgd
2iwgSz3a73CRP3C1+spIcOL0/Q1Ex68CKhm7EUELuna1i9g8vVPhMlxvaQRjRN+9
mWQ4szdOz0QeKSacDXyOdaBPk/TNngupPBRXnnSStKHd+i0QpKHtmU2JYZceyL5K
fb8vFOSMF0wm4UCGPPiSaIXtXpfSVkA1VWlW+vaHxqHLjG4lX7JcTp5CbeZcufmi
6iDAwj/S40x/H6p32b79pNKhQFgSzwO/PGqpxvyrRy6EokbzutPKGsrPBuBIRHrJ
yKLK3v8PlZ0QgXF3kO8JecuvWkibwznDV0F9gtdYGaRfbxFOBbUwg6ay87DWQh9s
jAt1Y4Rm9a/uXE/lezqSYK0hifD9XCUkxCtBaDYqctCbtwNtlYaqf8OciATYb+g2
tdFUf4xdWUvoa12SOc0P8KauHBSEoiAEsrCvkJsfgKbDnAu9N31caefCynxj513c
NspNL6Sx4w==
=f8pF
-----END PGP SIGNATURE-----

Attachment: pgpHt_f6kl9sD.pgp
Description: PGP signature


--- End Message ---
Reply to: