[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1122243: marked as done (libreoffice: Please include additional skia patch to fix FTBFS on alpha)

Your message dated Wed, 17 Dec 2025 05:00:10 +0000
with message-id <E1vVjdy-005nvD-0G@fasolo.debian.org>
and subject line Bug#1122243: fixed in libreoffice 4:26.2.0~rc1-1
has caused the Debian Bug report #1122243,
regarding libreoffice: Please include additional skia patch to fix FTBFS on alpha
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1122243: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1122243
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libreoffice
Version: 4:26.2.0~beta1-1
Severity: normal
Tags: patch
User: debian-alpha@lists.debian.org
Usertags: alpha
X-Debbugs-Cc: debian-alpha@lists.debian.org

Hi,

libreoffice currently fails to build on alpha with the following error:

[build MOD] jurt
./workdir/UnpackedTarball/skia/src/opts/SkRasterPipeline_opts.h: In function ‘atan2_n_floats’:
./workdir/UnpackedTarball/skia/src/opts/SkRasterPipeline_opts.h:4797:1: error: cannot tail-call: target is not able to optimize the call into a sibling call
 4797 | DECLARE_N_WAY_BINARY_FLOAT(atan2)
      | ^

This is because the skia source still defines SK_HAS_MUSTTAIL for alpha in
src/core/SkRasterPipeline.h.

This can be fixed with:

diff -Nru skia-old/src/core/SkRasterPipeline.h skia/src/core/SkRasterPipeline.h
--- skia-old/src/core/SkRasterPipeline.h        2025-11-13 07:45:03.000000000 +0100
+++ skia/src/core/SkRasterPipeline.h    2025-12-08 17:01:58.882479397 +0100
@@ -27,7 +27,7 @@
 struct skcms_TransferFunction;
 
 #if __has_cpp_attribute(clang::musttail) && !defined(__EMSCRIPTEN__) && !defined(SK_CPU_ARM32) && \
-        !defined(SK_CPU_LOONGARCH) && !defined(SK_CPU_PPC) && \
+        !defined(SK_CPU_LOONGARCH) && !defined(SK_CPU_PPC) && !defined(__alpha__) && \
         !(defined(_WIN32) && defined(SK_BUILD_FOR_ANDROID_FRAMEWORK))
     // [[clang::musttail]] is disabled for the Android version of Skia running on Windows as it
     // causes crashes (This is probably related to http://crbug.com/1505442).

After including that patch, libreoffice builds fine on alpha:

 dpkg-genbuildinfo --build=any -O../libreoffice_26.2.0~beta1-1_alpha.buildinfo
 dpkg-genchanges --build=any -O../libreoffice_26.2.0~beta1-1_alpha.changes
dpkg-genchanges: warning: package libreoffice-report-builder-bin-nogui in control file but not in files list
dpkg-genchanges: info: binary-only arch-specific upload (source code and arch-indep packages not included)
 dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
 signfile libreoffice_26.2.0~beta1-1_alpha.buildinfo

Thus, I'm attaching the patch and leaving it up to the libreoffice maintainer how to
include it. Either as a separate patch in external/skia or merged into gcc-no-musttail.diff.

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

diff -Nru skia-old/src/core/SkRasterPipeline.h skia/src/core/SkRasterPipeline.h
--- skia-old/src/core/SkRasterPipeline.h	2025-11-13 07:45:03.000000000 +0100
+++ skia/src/core/SkRasterPipeline.h	2025-12-08 17:01:58.882479397 +0100
@@ -27,7 +27,7 @@
 struct skcms_TransferFunction;
 
 #if __has_cpp_attribute(clang::musttail) && !defined(__EMSCRIPTEN__) && !defined(SK_CPU_ARM32) && \
-        !defined(SK_CPU_LOONGARCH) && !defined(SK_CPU_PPC) && \
+        !defined(SK_CPU_LOONGARCH) && !defined(SK_CPU_PPC) && !defined(__alpha__) && \
         !(defined(_WIN32) && defined(SK_BUILD_FOR_ANDROID_FRAMEWORK))
     // [[clang::musttail]] is disabled for the Android version of Skia running on Windows as it
     // causes crashes (This is probably related to http://crbug.com/1505442).

--- End Message ---
--- Begin Message --- 
Source: libreoffice
Source-Version: 4:26.2.0~rc1-1
Done: Rene Engelhard <rene@debian.org>

We believe that the bug you reported is fixed in the latest version of
libreoffice, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1122243@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated libreoffice package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 16 Dec 2025 21:47:37 +0100
Source: libreoffice
Architecture: source
Version: 4:26.2.0~rc1-1
Distribution: experimental
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 1122243 1122336
Changes:
 libreoffice (4:26.2.0~rc1-1) experimental; urgency=medium
 .
   * New upstream release candidate
 .
   * debian/patches/skia-gcc-no-musttail.diff: also include alpha
     (closes: #1122243)
   * debian/patches/remove-JITC_PROCESSOR_TYPE-setting.diff: as name says.
     Obsolete and fixes permissions of instdir/program/soffice during build
     (e.g. for smoketest) - closes: #1122336
 .
   * debian/rules:
     - use --enable-ld=mold if building rust-uno-bindings on riscv64 to speed up
       its linking/make it work
     - enable --enable-rust-uno on riscv64 (test-wise, it generally works and linking is
       far better with the above and does not hang anymore; compile still takes long but
       let's see - with parallelism output still might happen...)
   * debian/tests/test-rust_uno-example: increase timeout to 60s
   * debian/*.symbols*:
     - mark GLIBCXX_3.4 as optional, vanished in a (mold-using) riscv64 build, is
       not in our namespace anyway and we get a far more uptodate libstdc++6
       dependency anyway
Checksums-Sha1:
 2b0eee6b3cb0cb21c4aad68138538da9858615fe 38694 libreoffice_26.2.0~rc1-1.dsc
 9d41f16f652775d7ce835e699a1e23faed991129 57587812 libreoffice_26.2.0~rc1.orig-helpcontent2.tar.xz
 4ffe9068bb0826f89363f75a5d2e9a3ef29d8637 233598808 libreoffice_26.2.0~rc1.orig-translations.tar.xz
 2b06c8e23418796df00f3c3ce9ec4d2f5cf13174 290824368 libreoffice_26.2.0~rc1.orig.tar.xz
 6f6ce52606fa4f3a65d71441dc8c4eec5212dca6 833 libreoffice_26.2.0~rc1.orig.tar.xz.asc
 678ae30f38c8dff99b616fea280813667f499bbe 26635476 libreoffice_26.2.0~rc1-1.debian.tar.xz
 c0fbee8aa0c8c4d2df2cb9a5d0d0534b6d7abe12 27738 libreoffice_26.2.0~rc1-1_source.buildinfo
Checksums-Sha256:
 dbe0bb9474c63d46c1cfefa5fd4ed5dd4e2eef6b15c66a77cc4ebeafd287a2df 38694 libreoffice_26.2.0~rc1-1.dsc
 7fa5040c27af33e11778f8decc72006f1fdbfaefa195dd53ce8c7da91963a8b8 57587812 libreoffice_26.2.0~rc1.orig-helpcontent2.tar.xz
 2252ff9931d802592473947579e760da98d21838305fef7c540318d119e5fecd 233598808 libreoffice_26.2.0~rc1.orig-translations.tar.xz
 ad687c35ec16e22a06480f6716f563c02d5bc9ac6691da774b03d9d3c8000101 290824368 libreoffice_26.2.0~rc1.orig.tar.xz
 0a2fc89ba53780bd0b24128374f00d1f91ade3a9e34b526b00db5a5ad3624885 833 libreoffice_26.2.0~rc1.orig.tar.xz.asc
 9801be65186257dca117bdf3e84b9c94898230b34b7d2251b9f724be6b6bc600 26635476 libreoffice_26.2.0~rc1-1.debian.tar.xz
 d01864fbdd6844b12c4d2a7da5c78965bb946d5609dd7cfb2fe6357cb556ab5c 27738 libreoffice_26.2.0~rc1-1_source.buildinfo
Files:
 cee0f96e5218eaca67f8af27b1d4a69a 38694 editors optional libreoffice_26.2.0~rc1-1.dsc
 79c8031060a9ff3d3a64a5c83d9980b2 57587812 editors optional libreoffice_26.2.0~rc1.orig-helpcontent2.tar.xz
 2d958d0eae80655ea0ad13c0fe69e66a 233598808 editors optional libreoffice_26.2.0~rc1.orig-translations.tar.xz
 ea4bf97e1f6aa199c345438fc25361e0 290824368 editors optional libreoffice_26.2.0~rc1.orig.tar.xz
 ebabc586dbcb8e620eb6e4be7ebd4dcc 833 editors optional libreoffice_26.2.0~rc1.orig.tar.xz.asc
 3ef525ef6c22e230102c6f32f0793261 26635476 editors optional libreoffice_26.2.0~rc1-1.debian.tar.xz
 4ded57b57800c90270c51db53503c7fc 27738 editors optional libreoffice_26.2.0~rc1-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAmlByvcQHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cNmzD/9/kYymWTD3NE6W+FeSgcbb1sscl/Z+yeGy
tMI5FhcMwoWsILM7g6XplrS3jL9/AK85bz7bSEUjbvCciY6w9pDK8K+ewzYLdQvC
gnyBRSGtmkG18zodYR47CnpoNhIVICHYDvZ6QY4KtvNelGDb9Rcljnutb7Gz5g2q
ZIqWqWKtpNyP4UZ7wg6Xig3noPkzjTKCmymNO5p6bFBNvWsqIy27w0YaxT1HtD7Y
fXImlfOmRo2lwzDRZ5BULNpPiI5UgtRVcmQko4Hyuyo+9bw5kcy980IoAvn3Ed7W
/8oTuperCtDalitZ91vcShZPT83stwH/qDcPsIvrvmS9EOIpzsh/FmmJ8u5U+12Y
iDhPo7y3FzWalCpnklUrd+pfxGJylQAxkiwSFE6QFb1QMbyyZJTqWeNijhyfN+PD
EYlMKZhrhoxnw5LZ4Rd+D2OFEwyCtk/iBXIk5t3CmRHaka+GkBbz7gAZfdeDZl5q
r/Rycnf1FN45p139ctyyAi45omDm9PMBRHAANfYsMSaxeMd/ple2iIWE4QClTvnv
LS8oxYyoyY+XYpRXi4Hd9zWu6ib6Ysi1fYUeLPBAvhy8LUN2wnDZLRptU65UDfZL
14RRJu+ahYIJCoxbGSMf+9eeklJeSKWg2oFXwXzFdXLMm1LmyYUADS6A7IN2A5Gv
uQpU+kG8vw==
=BxmX
-----END PGP SIGNATURE-----

Attachment: pgpew5KWSKlIJ.pgp
Description: PGP signature


--- End Message ---
Reply to: