Please find, for review, the debconf templates and packages descriptions for the openoffice.org source package. This review will last from Friday, October 09, 2009 to Monday, October 19, 2009. Please send reviews as unified diffs (diff -u) against the original files. Comments about your proposed changes will be appreciated. Your review should be sent as an answer to this mail. When appropriate, I will send intermediate requests for review, with "[RFRn]" (n>=2) as a subject tag. When we will reach a consensus, I send a "Last Chance For Comments" mail with "[LCFC]" as a subject tag. Finally, the reviewed templates will be sent to the package maintainer as a bug report, and a mail will be sent to this list with "[BTS]" as a subject tag. I didn't review the giant debian/control files and packages' descriptions. At first glance, they are fairly good and I suspect there are already some translations which I don't want to break for such an important package. Rationale: --- openoffice.org.old/debian/templates 2009-10-09 06:46:12.982559264 +0200 +++ openoffice.org/debian/templates 2009-10-09 07:41:19.043166570 +0200 @@ -1,8 +1,10 @@ Template: openoffice.org/running Type: error -_Description: OpenOffice.org running! +_Description: Running instance of OpenOffice.org Avoid exclamation marks. Debconf templates should not be emotional but factual. OpenOffice.org is running right now. A running OpenOffice.org makes extension (de-)registration not possible and it causes problems with (de-)registering components. . - Please close OpenOffice.org (including an eventually running Quickstarter). + You should close all running instances of OpenOffice.org before + proceeding with the package upgrade (including an eventually running + Quickstarter). Let's be a little bit more precise as there may be more than one instance running (on multi-user machines, for instance). The current wording is more adapted for a single-user machine here the user doing the upgrade is the one also running the software. Also, let's be more complete: the package upgrade will not happen unless running instances are closed. --
Template: openoffice.org/running Type: error _Description: Running instance of OpenOffice.org OpenOffice.org is running right now. A running OpenOffice.org makes extension (de-)registration not possible and it causes problems with (de-)registering components. . You should close all running instances of OpenOffice.org before proceeding with the package upgrade (including an eventually running Quickstarter).
--- openoffice.org.old/debian/templates 2009-10-09 06:46:12.982559264 +0200 +++ openoffice.org/debian/templates 2009-10-09 07:41:19.043166570 +0200 @@ -1,8 +1,10 @@ Template: openoffice.org/running Type: error -_Description: OpenOffice.org running! +_Description: Running instance of OpenOffice.org OpenOffice.org is running right now. A running OpenOffice.org makes extension (de-)registration not possible and it causes problems with (de-)registering components. . - Please close OpenOffice.org (including an eventually running Quickstarter). + You should close all running instances of OpenOffice.org before + proceeding with the package upgrade (including an eventually running + Quickstarter).
Attachment:
signature.asc
Description: Digital signature