[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-octave-devel] New upload of octave-pkg-dev with autopkgtest capabilites



On Fri, Sep 01, 2017 at 10:19:49PM +0200, Sébastien Villemot wrote:
> On Fri, Sep 01, 2017 at 09:58:27PM +0200, Rafael Laboissière wrote:
> > * Rafael Laboissière <rafael@debian.org> [2017-09-01 21:33]:
> > 
> > > * Sébastien Villemot <sebastien@debian.org> [2017-09-01 17:04]:
> > > 
> > > > [snip]
> > > > 
> > > > The only downside IMO is that we are now dependent on the reactivity
> > > > of the autodep8 maintainers (but I guess they will be happy to
> > > > integrate our patch).
> > > 
> > > autodep8 is maintained under collab-maint.  Any DD has the appropriate
> > > access rights to the Git repository.  Getting the patch accepted should
> > > not be a big deal.
> > 
> > I just committed the changes for adding support for the OF packages
> > in autodep8: https://anonscm.debian.org/cgit/collab-maint/autodep8.git/commit/?h=octave&id=4805567b1866aa582eb7acca0a38dc3d28d3224d
> > 
> > I also upload version 1.5.0 of octave-pkg-dev to unstable.  As soon as the
> > new autodep8 package with octave support is released, we can start adding
> > "Testsuite: autopkgtest-pkg-octave" to the DOG packages.
> 
> Fantastic! I have told the news to terceiro on #debian-qa, let’s wait for his
> feedback.

Here is the discussion I just had with him:

22:05 < sebastien> terceiro: support for octave-* in autodep8 has just been committed on a new octave branch by Rafael Laboissière https://anonscm.debian.org/cgit/collab-maint/autodep8.git/commit/?h=octave
22:19 < terceiro> sebastien: "Try to select only the packages from Octave-Forge that are maintained by the Debian Octave Group" seems wrong
22:19 < terceiro> it should support all octave packages, not an arbitrary subset
22:20 < terceiro> and `Test-Command: debian/rules check-pkg` also looks wrong, as autopkgtest is intended to test the *installed* package and not the source package
22:21 < sebastien> the explanation to both of your remarks is that the test infrastructure is currently in octave-pkg-dev (which is our cdbs add-on)
22:21 < sebastien> so 1) we do not test packages that do not rely on that helper (though the description should be improved)
22:22 < sebastien> and 2) this actually tests the installed package (but through debian/rules because it is cdbs)
22:23 < sebastien> but maybe we should have that discussion by email, putting Rafael in the loop
22:23 < sebastien> should we open a bug against autodep8?
22:23 < terceiro> sebastien: sure
22:24 < terceiro> attach the patch to it so the bug is self-contained

So I suggest that you open a wishlist bug, with a possibly updated patch.

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org

Attachment: signature.asc
Description: PGP signature


Reply to: