Bug#1029398: ben: "tracker --archs" is not honoured
On Sun, Jan 22, 2023 at 01:35:09PM +0100, Stéphane Glondu wrote:
> Dear Adrian,
>
> Le 22/01/2023 à 12:33, Adrian Bunk a écrit :
> > $ ben download --archs alpha --preferred-compression-format xz --mirror-binaries http://ftp.de.debian.org/debian-ports
> > Downloading /tmp/Sources...
> > Downloading /tmp/Packages_alpha...
> > $ ben tracker --archs alpha -cd tracker
> > Parsing /tmp/Sources...
> > Parsing /tmp/Packages_amd64...
> > Parsing /tmp/Packages_arm64...
> > Parsing /tmp/Packages_armel...
> > Parsing /tmp/Packages_armhf...
> > Parsing /tmp/Packages_i386...
> > Parsing /tmp/Packages_mips64el...
> > Parsing /tmp/Packages_mipsel...
> > Parsing /tmp/Packages_s390x...
> > Parsing /tmp/Packages_ppc64el..
>
> "ben tracker" indeed seems to ignore its "--archs" option... and probably
> most of the options common to all ben frontends! Actually, it takes its
> configuration from the so-called "global" configuration file. Did you
> specify one (I see you've specified "-cd tracker", does it refer to
> something you wrote yourself)?
No, I have not created any configuration file (tracker/ just contains
.ben files for testing/using trackers locally).
> I'm afraid the default one is the Realase
> Team's one [1], which doesn't seem useful elsewhere...
Usually they are pretty useful for me since usually I am just using this
for sending new/changed trackers as MRs to the release team.
> [1] /usr/share/doc/ben/examples/tracker/global.conf
>
> By writing a custom global.conf (see comments in [1]), I can make "ben
> tracker" work with debian-ports and only alpha...
I ended up editing the defaults in lib/benl_base.ml and recompile ben,
but that's just a short-term hack.
> I see two approches to solving this bug:
> - make the command-line options override the configuration specified in
> global.conf
> - reject command-line options when they are read in global.conf
>
> What do you think?
>...
The behaviour of "ben download" of having some sane defaults[1]
or configuration file that can be overridden on the command line
is IMHO pretty good, and I'd expect "ben tracker" to behave the
same way.
> Cheers,
cu
Adrian
[1] but [2] would be a better compression default
[2] https://salsa.debian.org/debian/ben/-/merge_requests/2
Reply to: